Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

onFragment() deprecated? #751

Closed
egueli opened this issue Aug 11, 2018 · 3 comments
Closed

onFragment() deprecated? #751

egueli opened this issue Aug 11, 2018 · 3 comments
Labels

Comments

@egueli
Copy link

egueli commented Aug 11, 2018

Hi all,

the application I'm maintaining overrides WebSocketServer.onFragment(Websocket, Framedata). The IDE marks that method as deprecated, because of this annotation:

  • why is onFragment deprecated?
  • what should one do instead?

Thank you for any information!

@egueli
Copy link
Author

egueli commented Aug 11, 2018

I see this is related to #570.

If I read correctly the changes, WebsocketListener.onWebsocketMessageFragment() will never be called anymore and neither will WebsocketServer.onFragment()?

@marci4
Copy link
Collaborator

marci4 commented Aug 11, 2018

Hello @egueli,

These changes where made since most of the users expected to receive all messages using OnMessage regardless of how the message was sent.
You're application should work without any problems by simply using OnMessage (string/bytebuffer)

Best regards,
marci4

@egueli
Copy link
Author

egueli commented Aug 12, 2018

Thank you. In my case, there wasn't much logic in onFragment so I could remove it altogether.

@egueli egueli closed this as completed Aug 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants