-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build failure when builddir contains spaces. #65
Build failure when builddir contains spaces. #65
Comments
Confirmed. It looks like it might be a gyp bug, but I'll have to experiment a little bit more. |
As a workaround, set your |
Any updates to this issue? |
Added a pull that fixes at least the node-dtrace-provider (and hence the node-bunyan) issues mentioned here: #164 |
This still seems to be an issue... any progress on it? Setting the HOME env var didn't seem to help, though I may not be doing that correctly. |
I still think this is an issue, @jmwohl. Looking at the latest commit: https://github.com/TooTallNate/node-gyp/blob/7e98c99ce7e04e1599677a8b7919f7c387ad6a09/lib/configure.js#L311 Looks like Pull Request was never merged: #164 Proposed Solution (lines 311+), from @trentm:Oldargv.push('-Dnode_root_dir=' + nodeDir)
argv.push('-Dmodule_root_dir=' + process.cwd()) FixedAdd: function shellEscape(str) {
return str.replace(/(["\s'$`\\])/g, '\\$1');
}; Change to: argv.push('-Dnode_root_dir=' + shellEscape(nodeDir))
argv.push('-Dmodule_root_dir=' + shellEscape(process.cwd())) Maybe I am missing something? My only confirmation that it is still not working is from the issue I made on another repository: nodegit/nodegit#123 Hope this can be resolved and merged soon! Update: |
Fixes nodejs#65. Build failure when builddir contains spaces. Solution by @trentm. See trentm@bbd979b
This is an Open Issue:
workaround not working for me too |
Work-around (definitely OS X, probably unix*) until this is fixed:
npm install -g PACKAGENAME (this worked for me, to install zmq) |
Bump I guess? This still is an issue afaik. |
I am still having this issue here is a log output.
|
yep, still an issue:
|
Any progress on this? |
👍 Not just a Windows issue: I'm trying to install an Atom plug-in that uses node-gyp as a dependency, and my ~/.atom is stored on my cloud, by symlinking it to my "Google Drive" folder. I can't exactly rename that folder to not have a space, as it's tied into Google Drive's software... Seems like this is a case for delimiting strings using a null character rather that splitting at spaces, kind of like |
Still an issue on Mac OS X 10.9.5. |
It's probably going to remain an issue, my recommendation is to either https://support.apple.com/en-us/HT201548 On Wed, Jul 15, 2015 at 9:45 AM, David Rhoderick notifications@github.com
|
Same issue here, can't build on Big Sur when path contains spaces and I have no control on the folder name |
@jasondavies macOS workaround above #65 (comment) |
Thanks, that's not exactly the problem, I should have explained it better : |
Use backslash… |
Thanks Christian but that won't work. Looks like there's nothing we can do about it as the problem comes from gyp itself, not node-gyp 😐 |
Cannot believe this bug has existed for 10 years!!! |
When I move my projects to a mobile hard disk, I have a problem from 10 years ago |
By the way, I created a PR for this last year but it hasn't seen any movement: #2556 |
It looks so easy to fix. |
Can this be looked at, please? |
Can we have a GitHub Action that fails which demonstrates this problem? Which pull request should be reviewed? |
Fix an installation issue that occurs when a path in which node-gyp is run contains spaces. For a path like `my app`, it would error with this message: ``` clang: error: no such file or directory: 'app/node_modules/node-addon-api' ``` The "my" part before the space (and the rest of the path before it) would be missing from the path in the error message. Fixes nodejs/node-gyp#65
Fix an installation issue that occurs when a path in which node-gyp is run contains spaces. For a path like `my app`, it would error with this message: ``` clang: error: no such file or directory: 'app/node_modules/node-addon-api' ``` The "my" part before the space (and the rest of the path before it) would be missing from the path in the error message. Fixes nodejs/node-gyp#65
on osx: works:
fails:
|
See also: brianmcd/contextify#30.
For example, a home directory of
Brad Old
causes the build to fail:Notice the
-I
parameter is not escaped.The text was updated successfully, but these errors were encountered: