Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supporting delivery_receipt_requested feature #321

Open
Rostyk opened this issue May 22, 2018 · 4 comments
Open

Supporting delivery_receipt_requested feature #321

Rostyk opened this issue May 22, 2018 · 4 comments

Comments

@Rostyk
Copy link

Rostyk commented May 22, 2018

Is it possible to add the acknowledgement of the message receipt?

@hypesystem
Copy link
Collaborator

Hi @Rostyk, could you elaborate on what you mean with this issue?

A link or a more elaborate description of the feature would be helpful 😄

@Rostyk
Copy link
Author

Rostyk commented May 22, 2018

In the FCM documentation (Receive delivery receipts section) it says:

For Android and Chrome client apps, you can get delivery receipts (sent from FCM to your app server) when a device confirms that it received a message sent by FCM.

So I was wondering if there's a possibility to add delivery_receipt_requested flag so FCM would send a delivery receipt when it receives confirmation that the device received the message.

@Rostyk
Copy link
Author

Rostyk commented May 22, 2018

Oh, Sorry, I just realized its GCM. Please disregard.

@hypesystem
Copy link
Collaborator

@Rostyk FCM is the new name for GCM. Unfortunately the name "FCM" is taken for npm libraries. This doesn't mean that we won't support FCM features, though, so let's look at this a bit further 😄

We can definitely support that new parameter. Would you be interested in making a PR for it? We'll be here to guide you through the required changes.

The primary change is adding the parameter to the list of supported ones in message-options.js

We would also need some tests of the new functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants