Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[React Spinner] TSUI does not remove Spinner overlay so can't interact with page #455

Closed
n-srg opened this issue Nov 24, 2017 · 1 comment

Comments

@n-srg
Copy link
Contributor

n-srg commented Nov 24, 2017

I periodically facing weird spinner behavior on my React app:

I run spinner by setting data-ts.blocking. After I remove this attribute (or set it to empty string '' does not matter), grey overlay and spinner animation disappear, but i can't interact with the page.
The reason is that
<div data-ts-spirit="ts.ui.CoverSpirit" class="ts-cover ts-spinnercover ts-transition" id="ts-spinnercover"></div>
blocks whole viewport. As shown above, it missing some classNames: _gui-hidden _gui-invisible

v9.3.8 and older

I can't make 100% repeatable case, but I face it every few page reloads. will update issue in case I will be able to make 100% working example

@ChuanTS
Copy link

ChuanTS commented Nov 25, 2017

I came across similar problem. Also in a React app, when call show-spinner and then call dismiss-spinner in very short delay, a div.ts-spinnercover will cover the whole page making it irresponsible.

@DocGroth DocGroth added this to the tradeshift-ui@9.3.0 milestone Nov 28, 2017
@DocGroth DocGroth modified the milestones: tradeshift-ui@9.x, tradeshift-ui@10.x Jan 5, 2018
@DocGroth DocGroth closed this as completed Jan 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants