Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HystrixThreadPool to the stream #5

Open
bhugot opened this issue May 11, 2017 · 2 comments
Open

Add HystrixThreadPool to the stream #5

bhugot opened this issue May 11, 2017 · 2 comments

Comments

@bhugot
Copy link

bhugot commented May 11, 2017

Hi,
There is a missing part of stream for HystrixThreadPool.

Would be nice to have it

@markvincze
Copy link
Contributor

Hi @bhugot,

You mean that HystrixThreadPoolMetrics doesn't have a real implementation, it's just returning dummy values, right?

@JorritSalverda do you remember what is the status of that? I remember we had some technical limitations preventing us from properly implementing this at the time. Or is it just that we haven't got around to do it yet?

@JorritSalverda
Copy link
Contributor

@markvincze @bhugot The tracking of thread pool metrics in the original Hystrix library makes sense because you can create multiple thread pools in Java. However when I ported the library to .net I found out there's no such thing in asp.net. I did collect some metrics briefly to see if was of any use in the Hystrix dashboard, but it turned out to be really useless, so we might as well remove it altogether.

To get a better understanding of your thread pool metrics I would look at using Prometheus and the WMI exporter to collect those.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants