feat: 107 use video texture #167
Conversation
✅ Deploy Preview for cientos-tresjs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
src/core/loaders/useVideoTexture.ts
Outdated
| }) | ||
| const texture = new VideoTexture(video) | ||
| video.addEventListener(unsuspend, () => res(texture)) | ||
| video.addEventListener('error', () => rej()) |
There was a problem hiding this comment.
| video.addEventListener('error', () => rej()) | |
| video.addEventListener('error', (err) => rej(err)) |
There was a problem hiding this comment.
The error object is pretty much useless, so I'll keep the error log message
src/core/loaders/useVideoTexture.ts
Outdated
| } | ||
|
|
||
| function loadTexture(): Promise<VideoTexture> { | ||
| return new Promise((res, rej) => { |
There was a problem hiding this comment.
As a piece of general advice, try to avoid using acronyms or shorter versions of words when naming variables and methods, is always more important readability vs saving what, couple of letters?
new Promise((resolve, reject) => {
Less cognitive load when reading the code ;)
There was a problem hiding this comment.
@JaimeTorrealba please use resolve and reject. Avoid shorting variable and method names
src/core/loaders/useVideoTexture.ts
Outdated
| } | ||
|
|
||
| function loadTexture(): Promise<VideoTexture> { | ||
| return new Promise((res, rej) => { |
There was a problem hiding this comment.
@JaimeTorrealba please use resolve and reject. Avoid shorting variable and method names
closes #107