Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: 23 html component #184

Merged
merged 39 commits into from
Sep 27, 2023
Merged

feat: 23 html component #184

merged 39 commits into from
Sep 27, 2023

Conversation

alvarosabu
Copy link
Member

Closes #23

@alvarosabu alvarosabu added the feature New feature or request label Aug 25, 2023
@alvarosabu alvarosabu marked this pull request as draft August 25, 2023 16:12
@netlify
Copy link

netlify bot commented Aug 25, 2023 •
edited
Loading

✅ Deploy Preview for cientos-tresjs ready!

Name Link
🔨 Latest commit b8b1b68
🔍 Latest deploy log https://app.netlify.com/sites/cientos-tresjs/deploys/6513c70e5e3b2d00089abbd1
😎 Deploy Preview https://deploy-preview-184--cientos-tresjs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@alvarosabu alvarosabu marked this pull request as ready for review September 15, 2023 16:57
JaimeTorrealba
JaimeTorrealba requested changes Sep 19, 2023
View reviewed changes
docs/.vitepress/config.ts Show resolved Hide resolved
src/core/staging/Sky.vue Outdated Show resolved Hide resolved
src/core/misc/HTML.vue Outdated Show resolved Hide resolved
src/core/misc/HTML.vue Outdated Show resolved Hide resolved
src/core/misc/HTML.vue Outdated Show resolved Hide resolved
JaimeTorrealba
JaimeTorrealba approved these changes Sep 25, 2023
View reviewed changes
Copy link
Member

@JaimeTorrealba JaimeTorrealba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix that little details and if you want let's not merge until the 3.4 is out.

Meanwhile, I will review the environment

src/core/misc/html/HTML.vue Show resolved Hide resolved
docs/guide/misc/html-component.md Outdated Show resolved Hide resolved
@alvarosabu alvarosabu merged commit 3a488f0 into main Sep 27, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JaimeTorrealba JaimeTorrealba JaimeTorrealba approved these changes

@Tinoooo Tinoooo Awaiting requested review from Tinoooo

Assignees
No one assigned
Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

HTML component
2 participants
@alvarosabu @JaimeTorrealba