fix(Levioso): changing speed causes jerkiness #212
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #208
Before (
speed
scaleselapsed
):scale_elapsed.mov
After (
speed
scalesdelta
):scale_delta.mov
Refactors
I took the initiative to do a few refactors, each in separate commits:
ref
:offset
props.range
Please especially have a look at the last one:
props.range
is assigned a default value. It seems to me that it can't benull
orundefined
. It's typed as[number, number]
, so the type checker should signal an error, e.g., if:range="[1]"
.The other
props
fields don't have null checks.So I removed the null checks on
props.range
, but maybe I'm missing something.Thanks!