-
-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 178 v distance to #220
Conversation
✅ Deploy Preview for cientos-tresjs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@andretchen0 I know if a lot to see, but if you find time, without rush please check this too Also, if you have a better solution of how to show the distance will be appreciated, I'll just console.log it, because create a 3D text will be too much |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as advertised. 👍
There a couple language changes to make in the docs. Nothing major.
Otherwise, I made some suggestions:
- Based on the comments in the code, you were looking for a way to incorporate other displays. I made a suggestion for the API, but feel free to implement or not.
- Currently, passing a null ref to
v-distance-to
throws an unhandled error. With Vue, a lot of times it's easier to start with a null ref in the setup. So, I'd prefer to have a guard in this component to do some type checking, then either fail silently orconsole.warn
if the ref isn't an object with a position. But it's your call.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Just one more thing! 🤪
If I was better with Typescript I could definitely do something better, but for now I'll validate manually :D I appreciate this feedbacks |
@andretchen0 I'll be on vacations from 14 - oct, to 04 nov So I'll not make more PRs for now, please take care of cientos 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Sounds good. See you in november! |
@andretchen0 Hey there! Thanks for taking care of reviewing, what do you think, ready to merge? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty handy @JaimeTorrealba
It's ready to go, I believe. |
closes #178