Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cientos): Add CustomShaderMaterial wrapper #261

Merged
merged 9 commits into from
Oct 26, 2023
Merged

feat(cientos): Add CustomShaderMaterial wrapper #261

merged 9 commits into from
Oct 26, 2023

Conversation

kekkorider
Copy link
Collaborator

This PR adds a <CustomShaderMaterial /> wrapper around the CustomShaderMaterial package.

At the moment the dedicated playground page displays a black torus knot despite the properties I'm passing to it 🥲

@alvarosabu @JaimeTorrealba I'm here again asking for your support 🥲

Screenshot 2023-10-19 alle 16 27 38

Closes #109

@kekkorider kekkorider added enhancement feature New feature or request labels Oct 19, 2023
@kekkorider kekkorider self-assigned this Oct 19, 2023
@stackblitz
Copy link

stackblitz bot commented Oct 19, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@netlify
Copy link

netlify bot commented Oct 19, 2023 •
edited
Loading

✅ Deploy Preview for cientos-tresjs ready!

Name Link
🔨 Latest commit 7abdf76
🔍 Latest deploy log https://app.netlify.com/sites/cientos-tresjs/deploys/65397ff69344cc00086ef1b7
😎 Deploy Preview https://deploy-preview-261--cientos-tresjs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@alvarosabu
Copy link
Member

@kekkorider let me check

@alvarosabu
Copy link
Member

Checking their docs:

When extending already extended material, variables, uniforms, attributes, varying, and functions are NOT scoped to the material they are defined in. Thus, you WILL get redefinition errors if you do not manually scope these identifiers.

Maybe that's the warning

Function copy already exists on CSM, renaming to base_copy

@alvarosabu
Copy link
Member

@kekkorider check now 😉

@kekkorider kekkorider marked this pull request as ready for review October 25, 2023 20:37
@kekkorider
Copy link
Collaborator Author

kekkorider commented Oct 25, 2023 •
edited
Loading

@alvarosabu @JaimeTorrealba I guess this is ready for review 🥸

For some reason the latest deploy failed, maybe a manual redeploy can fix this (?)

EDIT:
Fixed! It was just a typo.

@kekkorider kekkorider force-pushed the feature/109-custom-shader-material branch from 1185c72 to 7abdf76 Compare October 25, 2023 20:52
alvarosabu
alvarosabu approved these changes Oct 26, 2023
View reviewed changes
Copy link
Member

@alvarosabu alvarosabu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job man, looks pretty cool

@alvarosabu alvarosabu merged commit 43701f8 into main Oct 26, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvarosabu alvarosabu alvarosabu approved these changes

@JaimeTorrealba JaimeTorrealba Awaiting requested review from JaimeTorrealba

Assignees

@kekkorider kekkorider

Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Custom shader material
2 participants
@kekkorider @alvarosabu