Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML abstraction not removing DOM elements onUnmounted #309

Closed
5 tasks done
alvarosabu opened this issue Dec 13, 2023 · 0 comments · Fixed by #310
Closed
5 tasks done

HTML abstraction not removing DOM elements onUnmounted #309

alvarosabu opened this issue Dec 13, 2023 · 0 comments · Fixed by #310
Assignees
Labels
bug Something isn't working

Comments

@alvarosabu
Copy link
Member

Describe the bug

HTML abstraction doesn't get rid of the generated DOM elements when unmounted

Reproduction

https://play.tresjs.org/#eNqVVuty2jgUfpWzZHbYnQXb5NLpemmWhV7SnabNFP6V/hC2wEpkSSPJXIbh3fdIxmAn3ZQkHrDO5dOncxPb1kRT849SwbKgrbjVN4lmyoKhtlDAiVi8mbasmbaup4LlSmoLW9B0DjuYa5lDG93af9V0Q2JYMs5IKle3RHVg/PXDcCS51GNFEtqBz3IiBUWVYmJxQLGZpk0cR2tExJKYg9HAouzehInUTdsvesbsSAqrJTcduLE5f+rEqLDSOL+pSKQwFhYc3sB2KgASTon2LGNon70+fzscXbU7TmP8SUwMVhfUSwhXGYlhTrgpBaUJnmiyUTR+HABnIQurCiRYRSF+HBVnZI9hiZtRQvWuRttkcnUzuf2E5DERv/3uNP2wzBtmCReW5ooTS3EF0E/Z8hr6s8LiDjBIOEseMKc1lF+qd8zydnvE/xvaNyylbcCgjFHY3u36YYmDgKHD9RvUUrXszphIEX7BfckA/nn9HdVG0cSyJR2RnGoCsZKGWSYFWn/7swPu+T5tQVi5NbJ6FDu0W2qyJkD3vAP4RA4h1tKSShF14JbYLLj7WGr3MBVtjPIHKnNq9QZiohfG+fQ60AuuOnBR51PbeiKlQFCqGeGQuDSi175s6icIK4fnuSNF97jNEmJstyyo5rZDuf4BT0ey+ngR18v37r/p4dvGaiLMXOocU8nmtTqpRc5bZ73rG9YP8esAEDqEF54dc+ZS9zQzY5VRfczNySd7PxxGF8OfZuEt064apSD8E1tk9klGkNSlLyYmLBWo2qCiF5w3k7Tfpdyj7AEU9MNaB+LS2A13rxnGB5t5JtNNOXdyzCQTMUTY3gCKpKnv/nKZUUcshl4U/eoFK5ba7LDeTcUZzocS6Ce2ADOSPCy0LETa9aGK4SyK3D4Ig8PDE2x1WuVI7eZEBfdGCrwQPPx0r8B7IC43dLL6PHaKaSuzVpk4DJNUoH9KOVvqQFAbCpWHdfPBRXAVRDhCjA2dGK2nLT8GG8DlzH4JdumB8K/q8Htxcxe7ouRBEXEK94Pt4DKIgt4euRIGOXM+dWx3n52C6+wGiHj1Gvn+QU1eDwPerYWhJ8e3Zj7oRT7AOIzpOsib0d3bYQVrmr4AuHR4DhoNuynN2Qmglak7/GXwKuRsVod0iFiaO6xJa/Dem7PFo4pMZK4Yp/qLcl3brEzCuVz962WHe9v7ZDR5+IH83qxLyndYLFQvMdzHVGKPUluq340/0zW+H5S5TAu+T87/KL9SI3nhOJZmQ+xBpF2z82w/+gbD9p+Yd2s/cfaHahC1+BPDS79V4/BQa6Xguw+ct/fpGD0TpePJLoKLQ8B3/wELfEY7

Steps to reproduce

Just toggle the button, and see that the DOM element remains

System Info

System:
    OS: macOS 14.1
    CPU: (8) arm64 Apple M1 Pro
    Memory: 78.97 MB / 16.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 18.14.1 - ~/.nvm/versions/node/v18.14.1/bin/node
    Yarn: 1.22.19 - /usr/local/bin/yarn
    npm: 9.3.1 - ~/.nvm/versions/node/v18.14.1/bin/npm
  Browsers:
    Brave Browser: 119.1.60.125
    Chrome: 120.0.6099.71
    Firefox: 120.0
    Safari: 17.1
  npmPackages:
    @tresjs/cientos: ^3.6.0 => 3.6.0 
    @tresjs/core: 3.6.0-next.0 => 3.6.0-next.0 
    @tresjs/leches: 0.14.0-next.0 => 0.14.0-next.0 
    @tresjs/nuxt: 2.0.1-next.1 => 2.0.1-next.1 
    @tresjs/post-processing: 0.7.0 => 0.7.0

Used Package Manager

pnpm

Code of Conduct

@alvarosabu alvarosabu added the bug Something isn't working label Dec 13, 2023
@alvarosabu alvarosabu self-assigned this Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant