Replies: 3 comments 3 replies
-
|
Wow, it does even look professional! Nice work! Some comments though:
About the assets, instead of adding them to a new 'art' folder I think it's better to just link the existing ones from the graphics folder. The creative commons icon can be linked using the official badge Over all It's a really nice improvement and I would like to update it, thanks! |
Beta Was this translation helpful? Give feedback.
-
Thanks but it's not much, I'm cheating a bit.
Yes, when a version will suit you, I will do the replacement of the files (instead of leaving it in the art/ folder).
I understand, I will adapt it according to that, here are two proposals,
with a little color (but just a little ;)) does it come close to what you want?
Yes it is free, the author just wants to be credited (Image of presentation: Garry Killian) I just modified it a little.
these modified, but I'm not sure if this version is the right one (my current idea, not your comment), you'll have to give me your opinion, thanks.
I admit, I don't find it elegant, but it's personal, and it's your application, I will modify this
Just to make sure I understand, do you want me to place the newly added "screenshots" (0.png, 1.png etc...) in the listings/en-US/graphics/phone-screenshots folder in addition to the old ones? instead of the old ones? or do you want me to use the items in the current phone-screenshots folder for the readme, I'm not sure.
I was also planning to update the app store screenshots later, with the same type (screenshot surrounded on a transparent background), it looks very good on F-droid and Google Play store I think, what do you think?
Thank you, if the size matters (^^), I will return it to its original size
I'll take care of it.
Yes indeed, but it is less pretty (this modification is already in place, tell me if it suits you that way) I will make the others changes this afternoon. |
Beta Was this translation helpful? Give feedback.
-
No need to wait, it's your branch after all, just replace the file and use it directly. If necessary I'll take care of replace it before merging.
Hmm, I was thinking of something different, something like this: Btw, play store is very strict about the image sizes, the store says:
Ok, I think there is space for the credit in the readme and in the play store description.
Now it's ok!
None of the things I tried look good, so I think it's better to remove the links, yes. Just center them and remove the inline from
Replace the screenshots in listings/en-US/graphics/phone-screenshots with your, and link them. We can discuss the exact screenshots later if needed, but linking them allows the readme to by up-to-date without duplicates. I like your screenshots too.
As explained above, just replace the images with yours (it's your branch, you can do anything there) and when merging I'll make sure to replace them if needed. Basically remove the art folder.
That's it! What about centering it?
Hey! those look nice, but they seem hardcoded. Aren't there a dynamic mantainance badge? (oh, and the app is made in Java not Javascript ;) |
Beta Was this translation helpful? Give feedback.
-
|
Summary of (light) changes made:
|
Beta Was this translation helpful? Give feedback.
-
|
This discussion is being a bit hard to follow. Make a PR and we'll discuss the code there line by line. Continued on #44 |
Beta Was this translation helpful? Give feedback.
-
|
Yes, a little, i made the PR |
Beta Was this translation helpful? Give feedback.
-
Hi @TrianguloY , I had fun modifying your Readme to make it more visually appealing,
Here is the link to the branch where I made the modifications:
https://github.com/Ilithy/UrlChecker/tree/readme-rework
(Honestly) Do you like the changes? (This is not extraordinary, I am aware of it), I can of course adapt to your tastes, this is only a first draft (and this is only a proposal, nothing mandatory ^_°)
Beta Was this translation helpful? Give feedback.
All reactions