Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the Open & Share feature look like the old bottom sheet in Android <12 #182

Closed
3 tasks done
1fexd opened this issue Feb 19, 2023 · 6 comments
Closed
3 tasks done
Labels
enhancement New feature or request

Comments

@1fexd
Copy link

1fexd commented Feb 19, 2023

Describe a related problem (optional)

No response

Describe your suggested feature

It would be very cool if the Open & Share feature would look like the old "Open in App" which Android <12 had:

thread-133292175-12565258617601683546

It would also be cool if that design used Material3 and Material You.

Describe alternatives you've considered for your suggested feature

I have used OpenLinkWith, which has this exact feature, but does look kind of out-of-place on Android 13

Other details

Maybe I could try and help implement this feature

Acknowledgements

  • I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open issue.
  • I have written a short but informative title.
  • I will fill out all of the requested information in this form.
@TrianguloY
Copy link
Owner

Due to the dialog-like style of the app it would be hard to replicate the same bottom-sheet look, although changing it shouldn't be difficult and maybe worth testing...

As for the list-like feature, that's something already requested and with some tests by pablo: #47 (and some others, linked there I think).

If you want to try to implement it yourself that'd be wonderful!

@pressRtowin
Copy link

pressRtowin commented Feb 19, 2023

Just mentioning this here, since we talked about it in the other discussion that lead to this issue being created, but either in this suggested UI, or also in the existing UI, please include OpenLinkWith's feature of including the Application's package name when multiple applications with the same name are detected.

@1fexd
Copy link
Author

1fexd commented Feb 20, 2023

Just wanted to let you know guys: I have implemented the requested functionality in my own app which I will publish on Github/FDroid soon.

@1fexd 1fexd closed this as completed Feb 20, 2023
@Ilithy
Copy link
Collaborator

Ilithy commented Feb 20, 2023

Just wanted to let you know guys: I have implemented the requested functionality in my own app which I will publish on Github/FDroid soon.

Cool, if I may ask two questions:
Implemented as a replacement for the current behavior or as an option (enableable/disable) of the Open and Share module?
If the answer is yes is it possible to make a PR here with your addition? 🤗

In any cases thank you and congratulations for the work done

@1fexd
Copy link
Author

1fexd commented Feb 20, 2023

Implemented as a replacement for the current behavior or as an option (enableable/disable) of the Open and Share module?

Implemented as its own standalone app made to better integrate with Android 12+ by using Material3+You as a replacement of OpenLinkWith

@1fexd
Copy link
Author

1fexd commented Feb 21, 2023

I have uploaded an initial release here if you are interested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants