Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Bug report) Excess spacing in lists #341

Closed
ekenwere opened this issue Aug 14, 2024 · 4 comments
Closed

(Bug report) Excess spacing in lists #341

ekenwere opened this issue Aug 14, 2024 · 4 comments
Labels
awaiting feedback bug Something isn't working
Milestone

Comments

@ekenwere
Copy link

TriliumNext Version

0.90.4

What operating system are you using?

Windows

What is your setup?

Local (no sync)

Operating System Version

Windows 10

Description

First: great work all, thanks for taking up the torch and continuing this great project.

Using bulleted (or other lists) in a database migrated from Trilium, I noticed that there's a lot more spacing than usual between lines. This is how it looked on Trilium
image
And this is how it looks on Trilium Next
image
A review of the HTML indicates that, compared to the equivalent from Trilium, <p style="margin-left:0cm;"> is being added at the beginning of each line, leading to the excess spacing. Thus:

<ul><li>This is a test
    <ul><li>of multi-tiered bulleted lists.
        <ul><li>And shows the excessive spacing.
    </li></ul>
</li></ul>

Becomes

<ul><li><p style="margin-left:0cm;">This is a test</p>
    <ul><li><p style="margin-left:0cm;">of multi-tiered bulleted lists.</p>
        <ul><li><p style="margin-left:0cm;">And shows the excessive spacing.</p>
    </li></ul>
</li></ul>

Again, much obliged for the work.

Error logs

No logs.

@meichthys
Copy link

I can't seem to reproduce this on Linux or on the Web server.
Perhaps windows specific.

@eliandoran eliandoran added the bug Something isn't working label Aug 14, 2024
@eliandoran
Copy link

@ekenwere , it seems I am unable to reproduce it either, on Windows 11.
Does it happen every time for you? Did it happen when you typed out the list or did you copy-paste it from somewhere else?
It could be a CKEditor bug, since we've upgraded versions from the original.

@ekenwere
Copy link
Author

Hi all,

Sorry for the late reply.

Bizarrely, after spending the entire day struggling with the problem when I posted the bug report, I'm now having trouble reproducing it myself. I do have a couple of existing documents with the problem, but can't consistently reproduce it on new ones. If I can find a better way to consistently do so, I'll comment again.

@eliandoran
Copy link

@ekenwere , in the next release the issue should be fixed for existing notes as well since we now force zero margins on lists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting feedback bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants