Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support tags for service registration #10

Closed
tgross opened this issue Nov 6, 2015 · 4 comments
Closed

Support tags for service registration #10

tgross opened this issue Nov 6, 2015 · 4 comments
Labels
enhancement released

Comments

@tgross
Copy link
Contributor

tgross commented Nov 6, 2015

Allow the configuration of a service registration to include tags that the discovery backend can expose for consumption by backend handlers. (ex. "prod", "dev")
@tgross tgross assigned tgross and unassigned tgross Nov 6, 2015
@tgross
Copy link
Contributor Author

tgross commented Dec 14, 2015

@misterbisson this was one of your suggestions from my original notes. Do you have further thoughts on what this looks like?

@misterbisson
Copy link
Contributor

I'd leave this one in the icebox for now. Tagging for dev or prod is discussed in some contexts, but I'd rather isolate those environments in entirely different networks with separate discovery catalogs.

EDIT: ...otoh, the other big reason we want this is to support blue/green or rolling deploys.

@justenwalker justenwalker mentioned this issue Dec 21, 2015
Closed
@justenwalker justenwalker mentioned this issue Dec 30, 2015
Merged
@tgross tgross added the open PR label Dec 30, 2015
@tgross
Copy link
Contributor Author

tgross commented Jan 4, 2016

Merged in #59 and will be in the next release (0.0.6).

@tgross tgross closed this as completed Jan 4, 2016
@tgross tgross removed the open PR label Jan 4, 2016
@tgross tgross reopened this Jan 4, 2016
@tgross
Copy link
Contributor Author

tgross commented Jan 5, 2016

Released in https://github.com/joyent/containerbuddy/releases/tag/0.1.0

@tgross tgross closed this as completed Jan 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement released
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tgross @misterbisson