Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Discovery Backend Registration #143

Closed
justenwalker opened this issue May 3, 2016 · 2 comments
Closed

Refactor Discovery Backend Registration #143

justenwalker opened this issue May 3, 2016 · 2 comments
Labels

Comments

@justenwalker
Copy link
Contributor

justenwalker commented May 3, 2016

As we are going to support multiple backends, it would be good if we didn't have to alter global config parser so much.

I propose that we make the config more free-form (map[string]interface{}) and support hooking into keys using a Registration function. Discovery backends could call this registration in their func init() { ... } to register a handler for their key ("consul", "etcd", "zookeeper", ...)

I'll try an initial PR to get the idea out in a more concrete form. I think this will significantly improve how we parse the configuration file.

As a part of this enhancement, it would be good to push the discovery backends into their own package.

@tgross
Copy link
Contributor

tgross commented May 9, 2016

Merged in #144. I'm building a release for this now.

@tgross
Copy link
Contributor

tgross commented May 9, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants