Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Buffer constructor runtime deprecation - this package emits a warning on Node 10 #45

Closed
benjamingr opened this issue Mar 20, 2018 · 2 comments
Closed

Buffer constructor runtime deprecation - this package emits a warning on Node 10 #45

benjamingr opened this issue Mar 20, 2018 · 2 comments

Comments

@benjamingr
Copy link

Hey from Node.js here!,

Starting on Node 10 this package will emit deprecation warnings. See this guide on what you should do in order to migrate to Buffer.alloc/Buffer.from.

See nodejs/node#19079 for discussion around this change and why we can't make new Buffer work
@benjamingr benjamingr changed the title Buffer constructor runtime deprecation - this package breaks on Node 10 Buffer constructor runtime deprecation - this package emits a warning on Node 10 Mar 20, 2018
@ChALkeR ChALkeR mentioned this issue Mar 21, 2018
Closed
@ChALkeR
Copy link
Contributor

ChALkeR commented Mar 21, 2018

Fixed in PR #46

@melloc
Copy link
Contributor

melloc commented Aug 2, 2018 •
edited
Loading

Both TritonDataCenter/node-asn1#30 and #46 have been merged and published, so I believe this should no longer be an issue.

@melloc melloc closed this as completed Aug 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use Buffer.(from|alloc) instead of deprecated Buffer API ChALkeR/node-sshpk
3 participants
@ChALkeR @melloc @benjamingr