From 8551d311bcbf6c5ebdd544c1409001eb5ba8e26b Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Fri, 8 Jun 2018 13:18:27 -0700 Subject: [PATCH] build: use LC_ALL of C for maximum compatibility LC_ALL=en_US breaks on some systems (notably the SmartOS 16 configuration in our CI). Use LC_ALL=C instead. PR-URL: https://github.com/nodejs/node/pull/21222 Reviewed-By: Tiancheng "Timothy" Gu Reviewed-By: Anna Henningsen Reviewed-By: Richard Lau Reviewed-By: Gus Caplan Reviewed-By: Refael Ackermann Reviewed-By: James M Snell --- configure | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/configure b/configure index 5e365914d84715..dcb8b03ebc5f33 100755 --- a/configure +++ b/configure @@ -672,10 +672,7 @@ def get_xcode_version(cc): def get_gas_version(cc): try: custom_env = os.environ.copy() - # smartos (a.k.a. sunos5) does not have the en_US locale, and will give: - # `setlocale: LC_ALL: cannot change locale (en_US): Invalid argument` - if 'sunos' not in sys.platform: - custom_env["LC_ALL"] = "en_US" + custom_env["LC_ALL"] = "C" proc = subprocess.Popen(shlex.split(cc) + ['-Wa,-v', '-c', '-o', '/dev/null', '-x', 'assembler', '/dev/null'],