From b6b019f37bcc72946f21de4db81d58ba53a0de1f Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Thu, 14 Jun 2018 21:28:06 -0700 Subject: [PATCH] doc: use imperative in COLLABORATOR_GUIDE Instead of wording the paragraph about communicating deprecations with the ecosystem as if it were directed at the ecosystem, write it as in imperative directed at the collaborator, since that is the audience for the COLLABORATOR_GUIDE. Instead of assuring the reader that a best effort will be made, instruct the reader to make the effort to communicate with the ecosystem. PR-URL: https://github.com/nodejs/node/pull/21340 Reviewed-By: Luigi Pinca Reviewed-By: Colin Ihrig Reviewed-By: James M Snell Reviewed-By: Vse Mozhet Byt Reviewed-By: Trivikram Kamat --- COLLABORATOR_GUIDE.md | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/COLLABORATOR_GUIDE.md b/COLLABORATOR_GUIDE.md index 8b7eafa9d2f041..238a72547247b6 100644 --- a/COLLABORATOR_GUIDE.md +++ b/COLLABORATOR_GUIDE.md @@ -463,11 +463,11 @@ Runtime Deprecation cycle. However, there is no requirement that deprecated code must progress ultimately to *End-of-Life*. Documentation-only and runtime deprecations may remain indefinitely. -A best effort will be made to communicate pending deprecations and associated -mitigations with the ecosystem as soon as possible (preferably before the pull -request adding the deprecation lands on the master branch). All deprecations -included in a Node.js release should be listed prominently in the "Notable -Changes" section of the release notes. +Communicate pending deprecations and associated mitigations with the ecosystem +as soon as possible (preferably before the pull request adding the deprecation +lands on the master branch). Use the `notable-change` label on all pull requests +that add a new deprecation or move an existing deprecation to a new deprecation +level. ### Involving the TSC