Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Twitter Crawler has been using "Name" instead of "ScreenName" for reblogs since data structures changed #473

Closed
deege216 opened this issue Sep 21, 2023 · 1 comment · Fixed by #474
Closed

Twitter Crawler has been using "Name" instead of "ScreenName" for reblogs since data structures changed #473

deege216 opened this issue Sep 21, 2023 · 1 comment · Fixed by #474

Comments

@deege216
Copy link
Collaborator

Not a huge deal ... but I noticed that several versions back the Twitter crawler began replacing %o with the blog's full "Name" (which is not unique and can change) instead of the previous "ScreenName". If that wasn't intentional, then it's a quick and easy fix on line 978 (version 2.11.3.0) of TwitterCrawler.cs. I changed my own but I wouldn't want to mess anything up in case that was a planned change. :)
@thomas694
Copy link
Contributor

You're right. That was unintentional. Would you like to contribute a PR?

@deege216 deege216 mentioned this issue Sep 23, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

closes #473 - Change user.Legacy.Name to user.Legacy.ScreenName deege216/TumblThree
2 participants
@thomas694 @deege216