Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skellam (special case) is broken with Zygote and SpecialFunctions >= 1 #156

Open
devmotion opened this issue Jan 7, 2021 · 7 comments
Open

Comments

@devmotion
Copy link
Member

Currently, these distributions are broken due to FluxML/Zygote.jl#873. As discussed in #155, the corresponding tests are marked as broken. The issue will be fixed upstream.

See also: TuringLang/DistributionsAD.jl#145

@devmotion
Copy link
Member Author

Copy from TuringLang/DistributionsAD.jl#145 (comment):

The main issue was fixed upstream, only some interesting issue due to Zygote._zero with ChainRulesCore.NotImplemented for matrices of Skellam variates is left: TuringLang/DistributionsAD.jl#172

@devmotion devmotion changed the title Skellam, NormalInverseGaussian, and Pareto (partly) are broken with Zygote and SpecialFunctions >= 1 Skellam (special case) is broken with Zygote and SpecialFunctions >= 1 Jun 3, 2021
@torfjelde
Copy link
Member

So I guess this can be closed?

@devmotion
Copy link
Member Author

No, Skellam is still broken with Zygote in one test.

@torfjelde
Copy link
Member

Do you know which one? I just had to remove a bunch of broken = (:zygote, ) to make tests pass in #177 so jus curious which one still remains.

@devmotion
Copy link
Member Author

Are you sure? I fixed these in #182, I thought.

@devmotion
Copy link
Member Author

devmotion commented Jun 5, 2021

Ah, it seems you updated the tests before merging the master branch. I updated this issue here when I fixed the tests in #182, so the remaining error is still not fixed.

@torfjelde
Copy link
Member

Aaaah, my bad; thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants