Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cholesky internals in ChainRules are changing #131

Closed
nmheim opened this issue Nov 20, 2020 · 0 comments · Fixed by #142
Closed

Cholesky internals in ChainRules are changing #131

nmheim opened this issue Nov 20, 2020 · 0 comments · Fixed by #142
Assignees
@nmheim

Comments

@nmheim
Copy link
Collaborator

nmheim commented Nov 20, 2020

JuliaDiff/ChainRules.jl#311 will remove chol_blocked_rev which is used here:

DistributionsAD.jl/src/common.jl

Line 11 in eb36932

∂A = ChainRules.chol_blocked_rev(f̄, factors, 25, true)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nmheim nmheim

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't depend on ChainRules internals TuringLang/DistributionsAD.jl
1 participant
@nmheim