-
-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Support cyrillic characters #27
Conversation
Codecov Report
@@ Coverage Diff @@
## master #27 +/- ##
===========================================
- Coverage 100.00% 99.40% -0.60%
===========================================
Files 1 1
Lines 158 168 +10
===========================================
+ Hits 158 167 +9
- Misses 0 1 +1
Continue to review full report at Codecov.
|
Hello @TwiN I work with @martinhrvn and I have a question. Is there any future release planned? If yes can you share the date? We would like to use this fix in our code so is there any chance to release v1.6.1 ? |
@omatija I'll release it in a couple minutes; I've just been very busy these past weeks, but since you need it now, I'll accommodate you :) |
Thank you for your contribution! Released in v1.6.1 |
Thank you very very much! :) |
This fixes #25
Root cause of this issue is that
strings.Index
returns byte index. So I switched the calculation of the indexes to use rune index as well as taking the string up to specified index and from specified index. Mabye the censored string could be changed to[]rune
and instead of callingtakeRunesFromIndex
we could just update thecensored
inplace.