Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: eslint excludes .json & ignored files (#316) #318

Merged
merged 1 commit into from
Jul 16, 2019

Conversation

eamodio
Copy link
Contributor

@eamodio eamodio commented Jul 16, 2019

Fixes #316

/cc @johnnyreilly

Copy link
Member

@johnnyreilly johnnyreilly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Thanks ♥️🌻

@johnnyreilly johnnyreilly merged commit 39fbffb into TypeStrong:master Jul 16, 2019
@johnnyreilly
Copy link
Member

This should be out in the next hour or two. Thanks @eamodio!

@eamodio
Copy link
Contributor Author

eamodio commented Jul 16, 2019

Thank, you, it was your solution 😉

@johnnyreilly
Copy link
Member

You say that... It was you that brought sensitivity: 'accent' to the party 😁

@eamodio
Copy link
Contributor Author

eamodio commented Jul 16, 2019

Haha -- yeah, such a strange api for doing an insensitive string compare. Couldn't be something like .equalsIgnoreCase or something obvious. But this is JS after all 😉

@piotr-oles
Copy link
Collaborator

🎉 This PR is included in version 1.4.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@benkaiser
Copy link

@piotr-oles has this regressed? I'm not seeing any usages of .isPathIgnored in the codebase now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using eslint support and seeing warnings for ignored files
4 participants