Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is it actual? #28

Closed
wclr opened this issue Feb 27, 2018 · 4 comments
Closed

Is it actual? #28

wclr opened this issue Feb 27, 2018 · 4 comments

Comments

@wclr
Copy link

wclr commented Feb 27, 2018

Noticed that ts-node stopped to use this module for resolving and reading config, is it still actual?

@blakeembrey
Copy link
Member

I'm not quite sure what the question is, sorry, but yes, ts-node no longer depends on this module.

@wclr
Copy link
Author

wclr commented Feb 27, 2018

So why you decided not to use this module? I mean are you going to support this module, and is it going to work correctly in future?

@blakeembrey
Copy link
Member

There's vague differences in the way tsconfig parses JSON vs TypeScript parsing JSON due to the internal TypeScript specific JSON parser. This results in something working with tsc and not working with ts-node. The goal was to always use the tsc version, but old TypeScript versions didn't expose it correctly.

The module should work in the foreseeable future and PRs are welcome, but trying to fix the minor differences and improving the errors to be in line with TypeScript would be a bit of a job. Welcome to accept a PR that does it, but right now TypeScript doesn't match any other JSON parser I know of (and even if it does, that can change later).

@wclr
Copy link
Author

wclr commented Mar 1, 2018

Ok, thanks for the elaboration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants