Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DownloadManager builds by newer GHA Windows runners fail to load #13

Closed
arch1t3cht opened this issue Dec 3, 2022 · 1 comment
Closed

Comments

@arch1t3cht
Copy link

arch1t3cht commented Dec 3, 2022

On recent GHA Windows runners, the libcurl wrap picks up zlib and libSSH2, and dynamically links against them. The resulting DLL will then fail to be loaded by LuaJIT on any machine that doesn't have these libraries installed.

Unfortunately, there's no working CI build of ffi-experiments that's still preserved, but the "Generate Windows Installer" step in the following two Aegisub builds also show this:

Disabling zlib and SSH2 support in curl via CMake options (see arch1t3cht@2618e45) solves this, though there might be some better and more general solution that just disables or hides all these optional dependencies.

@arch1t3cht
Copy link
Author

I can no longer reproduce this on the CI, so I'm guessing this was fixed in the runner image now. The paths searched by CMake also resemble those in the "good" run again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant