Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing courses in the generated image #4

Closed
HaoTian22 opened this issue May 12, 2024 · 3 comments
Closed

Missing courses in the generated image #4

HaoTian22 opened this issue May 12, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@HaoTian22
Copy link

download
image

Obviously, a lot of courses were missing.
I'm sure that I have copied and pasted the whole table, and the parser in step 1 works well.

image

@ecwu
Copy link
Member

ecwu commented May 12, 2024

Could you please save and upload your MIS timetable page as a HTML file here, so we can have a testing sample.

@HaoTian22
Copy link
Author

UIC MIS.zip

@ecwu ecwu closed this as completed in e41e46a May 12, 2024
@ecwu ecwu added the bug Something isn't working label May 12, 2024
@ecwu
Copy link
Member

ecwu commented May 12, 2024

The root cause for this bug is the original course merge logic can only handle a two hours session, when the course spans three hours, the time merging logic will returns a incorrect structure list.

  • What it should look like: [1,2,3]
  • What it return: [[1,2],3]

The new logic will check the length of the array first and apply different merge logic, and the correct image should generates

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants