From 4f975e383c2a081dfba598d9019182ad2132fc59 Mon Sep 17 00:00:00 2001
From: Alex Dryden <adryden3@illinois.edu>
Date: Thu, 13 Apr 2023 12:03:42 -0400
Subject: [PATCH] Update views to use dl format introduced in 4.x

---
 view/teams/index/role-detail.phtml | 23 +++++++++++++++--------
 view/teams/index/team-detail.phtml |  1 -
 view/teams/partial/user/view.phtml | 20 +++++++++-----------
 3 files changed, 24 insertions(+), 20 deletions(-)

diff --git a/view/teams/index/role-detail.phtml b/view/teams/index/role-detail.phtml
index 729b9a1..2aa50a9 100644
--- a/view/teams/index/role-detail.phtml
+++ b/view/teams/index/role-detail.phtml
@@ -3,6 +3,7 @@ $role = $this->role;
 $team_users = $this->team_users;
 $translate = $this->plugin('translate');
 $escape = $this->plugin('escapeHtml');
+$this->htmlElement('body')->appendAttribute('class', 'items show');
 
 $sectionNavs = [
     'item-metadata' => $translate('Info'),
@@ -21,14 +22,20 @@ $sectionNavs = [
 </div>
 
 <div id="item-metadata" class="active section">
-    <div class="meta-group">
-        <h4><?php echo $translate('Name'); ?></h4>
-        <div class="value"><?php echo $escape($role->getName()); ?></div>
-    </div>
-    <div class="meta-group">
-        <h4><?php echo $translate('Comment'); ?></h4>
-        <div class="value"><?php echo $escape($role->getComment()); ?></div>
-    </div>
+    <dl>
+        <div class="property">
+            <dt><?php echo $translate('Name'); ?></dt>
+            <dd class="value">
+                <span class="value-content"><?php echo $escape($role->getName()); ?></span>
+            </dd>
+        </div>
+        <div class="property">
+            <dt><?php echo $translate('Description'); ?></dt>
+            <dd class="value">
+                <span class="value-content"><?php echo $escape($role->getComment()); ?></span>
+            </dd>
+        </div>
+    </dl>
 </div>
 
 <div id="item-linked" class="section">
diff --git a/view/teams/index/team-detail.phtml b/view/teams/index/team-detail.phtml
index b831d50..25baa53 100644
--- a/view/teams/index/team-detail.phtml
+++ b/view/teams/index/team-detail.phtml
@@ -45,7 +45,6 @@ $sectionNavs = [
     <?php endif; ?>
 </div>
 <div id="item-metadata" class="active section">
-
     <dl>
         <div class="property">
             <dt><?php echo $translate('Name'); ?></dt>
diff --git a/view/teams/partial/user/view.phtml b/view/teams/partial/user/view.phtml
index 8c48de3..b385912 100644
--- a/view/teams/partial/user/view.phtml
+++ b/view/teams/partial/user/view.phtml
@@ -1,14 +1,12 @@
 
-<div class="property">
-    <h4>Teams</h4>
-    <?php         foreach ($this->team_users as $team_user):
-            ?>
-    <div class="values">
-        <?php             echo sprintf('%s (%s)<br>', $team_user->getTeam()->getName(), $team_user->getRole()->getName());
-            ?>
+<dl >
+    <div class="property">
+        <dt>Team(s)</dt>
+        <?php foreach ($this->team_users as $team_user): ?>
+        <dd class="value">
+            <?php echo sprintf('%s (%s)<br>', $team_user->getTeam()->getName(), $team_user->getRole()->getName()); ?>
+        </dd>
+        <?php endforeach; ?>
     </div>
-    <?php         endforeach;
-        ?>
-
-</div>
+</dl>