You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Zazzle integrated scrollToNode into Uize.Fx and it was suggested that we create a separate Uize.Fx.Scroll module in order to not unnecessarily weigh down Uize.Fx. The problem now is that Uize.Fx.Scroll still pulls in Uize.Fx even though it doesn't leverage any of the functionality, so we're also requiring all of Uize.Fx's depenencies.
Seems like what we really want is a Uize.Effects namespace (like Uize.Str) and then have a Uize.Effects.Styles module (for Uize.Fx) and then move Uize.Fx.Scroll to Uize.Effects.Scroll.
Thoughts?
The text was updated successfully, but these errors were encountered:
This issue is misnamed - the name doesn't convey the issue or intended action, which is not helpful when surveying the tasks. I suggest using action based naming that summarizes the proposed resolution. In this case, something like "Migrate Uize.Fx modules to under a Uize.Effects pure namespace"
Zazzle integrated
scrollToNode
intoUize.Fx
and it was suggested that we create a separateUize.Fx.Scroll
module in order to not unnecessarily weigh downUize.Fx
. The problem now is thatUize.Fx.Scroll
still pulls inUize.Fx
even though it doesn't leverage any of the functionality, so we're also requiring all ofUize.Fx
's depenencies.Seems like what we really want is a
Uize.Effects
namespace (likeUize.Str
) and then have aUize.Effects.Styles
module (forUize.Fx
) and then moveUize.Fx.Scroll
toUize.Effects.Scroll
.Thoughts?
The text was updated successfully, but these errors were encountered: