Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Uize.Fx modules to under a Uize.Effects pure namespace #32

Open
BenAtZazzle opened this issue Oct 30, 2013 · 2 comments
Open

Migrate Uize.Fx modules to under a Uize.Effects pure namespace #32

BenAtZazzle opened this issue Oct 30, 2013 · 2 comments

Comments

@BenAtZazzle
Copy link
Contributor

Zazzle integrated scrollToNode into Uize.Fx and it was suggested that we create a separate Uize.Fx.Scroll module in order to not unnecessarily weigh down Uize.Fx. The problem now is that Uize.Fx.Scroll still pulls in Uize.Fx even though it doesn't leverage any of the functionality, so we're also requiring all of Uize.Fx's depenencies.

Seems like what we really want is a Uize.Effects namespace (like Uize.Str) and then have a Uize.Effects.Styles module (for Uize.Fx) and then move Uize.Fx.Scroll to Uize.Effects.Scroll.

Thoughts?

@UIZE
Copy link
Owner

UIZE commented Jan 6, 2014

This issue is misnamed - the name doesn't convey the issue or intended action, which is not helpful when surveying the tasks. I suggest using action based naming that summarizes the proposed resolution. In this case, something like "Migrate Uize.Fx modules to under a Uize.Effects pure namespace"

@UIZE
Copy link
Owner

UIZE commented Jan 6, 2014

Either describe the issue or the proposed action, I guess I mean to say. A title like "Uize.Fx.Scroll" is not so helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants