Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enlarge Reporting the final lines and samples backwards #3659

Closed
AaronBoyd opened this issue Jan 24, 2020 · 3 comments
Closed

Enlarge Reporting the final lines and samples backwards #3659

AaronBoyd opened this issue Jan 24, 2020 · 3 comments
Assignees
@ladoramkershner
Labels
bug Something isn't working good first issue Good for newcomers Missions Issues which are a priority for missions

Comments

@AaronBoyd
Copy link

ISIS version(s) affected: 3.4.1(and probably before) through and including 3.9.1

Description
Enlarge reports the OutputLines as the output samples and the OutputSamples as the output lines

How to reproduce
run enlarge (and sscale and lscale)

view the results group generated to see the switch

Possible Solution
this appears to be just a typo that needs to be corrected.

Additional context

Group = UserParameters
FROM = image1
TO = image2
INTERP = nearest
MODE = SCALE
SSCALE = 1
LSCALE = 14
End_Group

Group = Results
InputLines = 78
InputSamples = 704
StartingLine = 1
StartingSample = 1
EndingLine = 78
EndingSample = 704
LineIncrement = 0.071428571428571
SampleIncrement = 1.0
OutputLines = 704
OutputSamples = 1092
End_Group
@jessemapel jessemapel added the bug Something isn't working label Jan 24, 2020
@jessemapel
Copy link
Contributor

Yep, looks flipped https://github.com/USGS-Astrogeology/ISIS3/blob/dev/isis/src/base/objs/Enlarge/Enlarge.cpp#L144

@jlaura jlaura added the Missions Issues which are a priority for missions label Jan 29, 2020
@scsides scsides added the good first issue Good for newcomers label Feb 6, 2020
@jlaura
Copy link
Collaborator

jlaura commented Mar 23, 2020

Enlarge Reporting the final lines and samples backwards

@ladoramkershner ladoramkershner mentioned this issue Mar 24, 2020
Merged
11 tasks
@acpaquette
Copy link
Collaborator

@ladoramkershner Can this be closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ladoramkershner ladoramkershner

Labels
bug Something isn't working good first issue Good for newcomers Missions Issues which are a priority for missions
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@jlaura @AaronBoyd @scsides @acpaquette @jessemapel @ladoramkershner