Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CTX images are using linear position interpolation instead of hermite #3928

Closed
jessemapel opened this issue Jun 18, 2020 · 6 comments · Fixed by #3940
Closed

CTX images are using linear position interpolation instead of hermite #3928

jessemapel opened this issue Jun 18, 2020 · 6 comments · Fixed by #3940
Assignees
Labels
ale bug Something isn't working

Comments

@jessemapel
Copy link
Contributor

ISIS version(s) affected: 4.1.0 (likely 4.0) and later

Description

When spiceinit'd with ISIS 4.1.0, some CTX images are using linear position interpolation instead of cubic hermite splines. This is causing errors on the order of a few meters vertically. Currently we've seen this with J03_045994_1986_XN_18N282W and J03_046060_1986_XN_18N282W so far. It is likely occurring in more images.

How to reproduce

Spiceinit the cube with ISIS3 and then spiceinit the cube with ISIS4. The InstrumentPosition CacheType will be HermiteSpline under ISIS3 and Linear under ISIS4.

Possible Solution

This is likely caused by the cache being significantly smaller when ALE creates it compared to ISIS.
Additional context

@jessemapel jessemapel added bug Something isn't working ale labels Jun 18, 2020
@kberryUSGS kberryUSGS self-assigned this Jun 25, 2020
@kberryUSGS
Copy link
Contributor

This is happening with HRSC images as well, and based on where this is happening in the code, I'd expect it to happen with any LineScanner in ISIS.

@jessemapel jessemapel mentioned this issue Jul 1, 2020
11 tasks
@kberryUSGS kberryUSGS removed their assignment Jul 2, 2020
@AndrewAnnex
Copy link
Contributor

@jessemapel can you confirm this issue is fixed as of 4.2.0, unfortunately Ames stereo is locked to 4.1.0 at the moment

@jessemapel
Copy link
Contributor Author

Just tested and it is still failing. Putting this on the todo list for next week :(

@jessemapel jessemapel reopened this Aug 8, 2020
@jlaura
Copy link
Collaborator

jlaura commented Aug 17, 2020

@jessemapel Is this on the list for this week or should I pull this as a candidate for the support sprint?

@jessemapel
Copy link
Contributor Author

@jlaura Put it in for support at this point. I don't think we'll have time to get to it this week.

@jessemapel jessemapel self-assigned this Aug 31, 2020
@jessemapel
Copy link
Contributor Author

Okay, confirmed this is fixed, but it just missed the 4.2 code freeze by 1 day. So, this will be out in 4.2.1 and 4.3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ale bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants