lrowaccal is nonfunctional on MacOS (Edit: On any system without kernels directory downloaded.) #4038
Comments
|
Update: It's not MacOS, it's not having the $Lro/kernels directory. Both of the above computers were relying on web SPICE, while the Linux system had local kernels. When I set up an Lro data directory without a kernels directory on that Linux system, I got the same 0 result. EDIT: If I add the contents of kernels/tspk/ and the de421 files from kernels/pck/, the radiometry correction works correctly. Not sure how this should be solved long-term, but it means there's a workaround of downloading ~20MB of kernels. |
rvwagner
changed the title
|
This is related to #1473 and was fixed for lronaccal in #3611 by first using the attached SPICE data on the cubes and then falling back to loading local kernels if that's not available. This is something the ASC is planning to address for all calibration programs this year. See: https://github.com/USGS-Astrogeology/softwaremanagement/tree/master/FY21#spice-calibration |
|
Labeling as a bug. Behavior should be to error and not create an invalid cube. Making lrowaccal work without local kernels is #1473 |
scsides
added a commit
to scsides/ISIS3
that referenced
this issue
Nov 9, 2020
… kernels necessary for calibration where not available. Closes DOI-USGS#4038
scsides
added a commit
to scsides/ISIS3
that referenced
this issue
Nov 9, 2020
kberryUSGS
added a commit
that referenced
this issue
Jan 12, 2021
* Update README.md to indicate that isis3VarInit.py is still the script name to use for the current relelase (#3962) * Update README.md * fixed formatting * typo * formatting again * Update based on feedback * add authors checklist item to pr template action item from last ISIS_TC meeting https://github.com/USGS-Astrogeology/ISIS_TC/blob/master/meetings/2020-07-14.md adds a step to the pr template for the author to make sure they add themselves to the authors.rst file * Updates Zenodo (DOI) (#3949) * Updates Zenodo (DOI) The DOI entered will now always resolve tot he newest release. The other DOI was pinned to a specific release. * Updates with a How to Cite section * Review comments addressed * Update README.md * Continuation of updating SpicePosition to use States (#3947) * Initial draft for feedback SpicePosition updated to use States * Added States to SpicePosition and SpiceRotaiton. Removed p_cache and p_velocityCache * Remove debug output and update ReloadCache to use current cache to populate new cache. * Initial updates to SpiceRotation * Update SpicePosition to completely use States for caching position and velocity values * Revert SpiceRotation to dev * Small amount of cleanup * Updated SpicePosition based on feedback * Update SpiceRotation * Update based on comments * fixed cache size * semi-colons * More dumb errors * Fixed bad velocity * Now properly passing cache reduction tolerance * actually reducing cache now * Properly reseting time cache after reduction * More clean up * More careful loading * Testing stuff * Compiling post merge * Fixed test ISDs * updates for unit tests * Fixed cache size check Co-authored-by: Kristin <kberry@usgs.gov> * Reverted change to camsolveAll test * Spice rotation update to use ALE (#3977) Updated SpiceRotation to use ale::Orientations * Create IssueLifecycle.md * Adds a draft .zenodo file to get authors names (#3950) * Adds a draft .zenodo file to get authors names * Updates the contirbuting text to also indicate docs updates needed for first time users * Making the conda recipe work again* (#3986) * changed nn dep * added kakadu incs path * added up to date ale * findale renamed * updated version * removed data vars, added buildTets=OFF * Includes are now packaged in conda builds. (#3989) * changed nn dep * added kakadu incs path * added up to date ale * findale renamed * updated version * removed data vars, added buildTets=OFF * updated scripts * reverted meta * removed commented out line * Added license to conda-build recipe * Update README with details about ISIS Data differences between 4.1 and earlier (#3985) * Update installation instructions * Update README.md * Update README.md * Updated based on feedback * Libisis now installs based on version string (#3992) * libisis3 -> libisis * added simple tests to meta * test stuff * reverty * removed commented out code * added tests : * addressed comments * Added a changelog (#3984) * Empty changelog with versions * Added changelogs from past releases * Updated PR template * Added an audience * Now installs properly * Fixed install paths * Typo fixes * Update file paths for data moved into the $ISISTESTDATA area. (#3991) * Update file paths for unit test-associated data which was moved into the /usgs/cpkgs/isis3/isis_testData area * Move paths for documentation-associated cubes/nets to $ISISDATA/base/examples * Fix incorrect path in comment * update gsl version to fix #3969 (#3993) * update gsl version to fix #3969 updates meta.yaml file to install a more recent version of gsl (>=2.6) * Update environment.yml missed this in initial commit * updated kaguyasp2isis docs to mention deprecation (#3996) * updated kaguyasp2isis docs to mention deprecation * added links * typo * whoops * typo * Updated equalizer output (#4000) * Fixed equalizer output * Added changelog * Added issue number * Stats Docs (#3923) * Updated stats documentation * Updated stats docs based on feedback * isis2raw pure export update (#4002) * Changed check and set range logic/removed duplicate code * Added history comment and moved function outside of if statement * Fixed pixel type prapogation and boolean logic * Addressed PR feedback * Updated the changelog * Add GUI helper to hist so user can see what the minimum and maximum DN values are of the specified band of the cube * Update CHANGELOG.md * changed map2cam to use virtual bands (#4008) * changed map2cam to use virtual bands * changelog * adressing comments * hideal2pds #3978 fix (#3998) * addresses #3978 * corrects for all but 16 bit compression * corrects for all but 16 bit compression organize template files and add 8bit version use 8bit template when 8bit Delete .nfs00000001d83de60d0000003e remove accidental file Updated equalizer output (#4000) * Fixed equalizer output * Added changelog * Added issue number Stats Docs (#3923) * Updated stats documentation * Updated stats docs based on feedback isis2raw pure export update (#4002) * Changed check and set range logic/removed duplicate code * Added history comment and moved function outside of if statement * Fixed pixel type prapogation and boolean logic * Addressed PR feedback * Updated the changelog Add GUI helper to hist so user can see what the minimum and maximum DN values are of the specified band of the cube Update CHANGELOG.md update CHANGELOG and rebase to upstream dev documentation update CHANGELOG and rebase to upstream dev documentation * Updated maptemplate docs (#4009) * changed map2cam to use virtual bands * updated maptemplate docs * typo * changed back to dist being from the center of the target * Added closing table row tag to stats docs (#4016) * FindImageOverlaps test (#4007) * Found old findimageoverlaps test code. Updated based on original PR review * Fix for centos build and other test failures * Added full overlap test and removed old test make files * Simple script to generate AUTHORS.rst from .zenodo.json file (#3995) * Add script to create AUTHORS.rst from .zenodo.json and update AUTHORS.rst * Update PR template and contributing docs * Removed json error in .zenodo.json and update script based on feedback * update based on more feedback * removed comment * Fixed FunctionalTestGetsnAllTrue by creating non-static APP_XML (#4022) * Fixed FunctionalTestGetsnAllTrue by creating non-static APP_XML * Replaced static APP_XML with per-test instances Co-authored-by: Austin Sanders <arsanders@ugs.gov> * zenodo and authors: Upgraded handling of the authors information. (#4024) * docs(zenodo and authors): Upgraded handling of the authors information. - Upgraded zenodo_to_authors.py to write out the AUTHORS.rst file in alphabetical order, and added affiliations, if any. - Created zenodo_order.py to re-arrange the "creator" list in the .zenodo.json file so that it is designated first author (project lead) followed by everyone else in alphabetical order. - Committed the new versions of .zenodo.json and AUTHORS.rst - Added my own name, affiliation, and ORCID iD * feat(zenodo_order.py): Made the first author designation a command line argument with a default, and altered some of the algorithm. * Resolve Test Failure: ThreeImageNetwork.FunctionalTestCnetcheckCamera (SEGFAULT) (#4035) * protect for null vals before SetImage * check for null, not special * Revert reverted histogram PR and handle conflicts. (#4004) * Revert reverted histogram PR and handle conflicts * Added changelog entry * ERROR * local stats fix * Added new ImageHistogram class * Actually added the ImageHistogram class * Made shared variable protected so subclass can access it * Used virtual functions and reverted Cube::histogram to return a Historgram * Added back pipe to dev/null in makefile * Fixes to some app and unit test in the hist PR * More test fixes * Final updates to programs and test data for new histogram calculations * Split the rolls of imagehistogram and histogram * Added and updated unit test truth data * Added the ImageHistogram unittest file * Resolved last comments on hist PR Co-authored-by: Adam Paquette <acpaquette@usgs.gov> * Removes /nomenclature from qisis FeatureNomenclature (#4030) * Moved SpiceRotation unit test to gtest (#4026) * Moved SpiceRotation unit test to gtest * Fixed typo and precision issues * One more precision fix * Removed OS truth data * Review clean-up * Added an ignore line for the new test (#4036) * Modified ALLLIBDIRS to just have paths with no file names. Used for l… (#4031) * Modified ALLLIBDIRS to just have paths with no file names. Used for loader -L option. Closes #3886 * Update CHANGELOG.md * Fixed reference of kakadu library for MacOS * Combined regexs and loops. Added special handling of .so's for MacOS * fixed local pointsstats and imagestats failures (#4042) * Added pre-changelog changes to the changelog These changes were all made prior to taking on our changelog, but I forgot to add them in the initial PR. * Updates labels generated by tgocassisrdrgen and filter information in tgocassis2isis (#4043) * Update filter/filter widths in tgocassis2isis labels * Adds the processing pipeline version to tgo exported labels * Added a sitch browse LID to the label and also updated the psa observation identifier to use the UID * Add new smithed kernel information * Fix tgocassisrdrgen to work on non-Mosaics again * Updated ProcessExportPds4's reorder function to re-order another top-level section: Reference_List * FindImageOverlap optional threaded computation (#4047) * Made the threaded calculation option in findimageoverlaps function call * Fixed type in test file name * Updated change log * Addressed PR feedback * Updated local radius test threshold * Updates dev for the 4.3RC pull/release (#4050) * Updates dev for the 4.3RC pull/release * Updated the changelog for the 4.3.0 RC * Removed manual define of KAKADU_INCLUDE_DIR in build.sh (#4051) * Add gtests for camrange (#4056) * camrange gtest * Update FunctionalTestsCamrange.cpp * Update camrange.h * Update camrange.cpp * remove old tests * Fix wrong APP_XML (#4059) * hicubenorm tests added (#4057) * starting hirise tests * added hirise tests * removed old tests * minor tweaks * updated from comments * now read only * newlines * Update main.cpp Co-authored-by: Stuart Sides <ssides@usgs.gov> * Adds the ability to arbitraily create image polygons from the set of coordinates * hicubenorm fix (#4066) * hicubenorm fix * typo * uuuuuugh, this is what happens when you try to pump out things fast * added Jenkins path to Kakadu * Update 4_Documentation_issue.md (#4068) * Update 4_Documentation_issue.md Change the psychologically disadvantageous emoji for documentation issues. * Update 4_Documentation_issue.md change to GH supported MD * Update 4_Documentation_issue.md had to copy the unicode in for it to render. * leisa2isis gtests (#4062) * Initial leisa tests * Converted leisa tests to gtest * Added raw fits file * fixed names Co-authored-by: Kelvin <kelvinrr@icloud.com> * added hicrop tests (#4072) * added hicrop tests * removed prints * fixed bugs * removed old tests * swapped header funcs * Apollofindrx Test added (#4061) * first run at apollofindrx tests * tests updated * removed old tests * Update FunctionalTestsApolloFindRx.cpp * Update apollofindrx.cpp * Update apollofindrx.h * changes from comments * updated tests with bigger cube * opened window for more cosistant tests and removed a rx point for faster tests * reverted small cube change Co-authored-by: Stuart Sides <ssides@usgs.gov> * Overlapstats test (#4073) * first commit * add all but errortest * remove broken gtest and old tests * rebase and address PR review * first commit * add all but errortest * remove broken gtest and old tests * Jigsaw to app conversion and remove unnecessary tests (#4075) * jigsaw to app conversion and remove unnecessary tests * Updated based on comments * Updated spacing * Remove apollo tests (#4090) * removed apollo tests * removed apollo tests * Jigsaw camsolveall (#4078) * jigsaw to app conversion and remove unnecessary tests * init jigsaw test * prints * prints * all my homies hate control networks * working tests * updated bundleadjust * bin 2 pvl * added csv check, addressed comments * removed header test * renamed to observation * also renamed in fixture * removed old tests Co-authored-by: Kristin <kberry@usgs.gov> * Initial constants unit gtest (#4081) * Initial constants unit gtest * removed old test files * Fixes broken link to astrodiscuss on README.md * Adds apollo fixture (#4080) * jigsaw to app conversion and remove unnecessary tests * Updated based on comments * Updated spacing * Adds apollo fixture for jigsaw tests * Updated to use pvl control network * Updated based on comments * remove accidental jigsaw test commit * Update Jigsaw apollo test based on feedback * Updated botched merge * Remove accidentally updated files * Adding a space to try to trigger Jenkins * added error tests for jigsaw (#4093) * added error tests * added some other error tests * added last test * addressed comments * missed a thing * removed useless test * Converted jigsaw apollo test (#4088) * jigsaw to app conversion and remove unnecessary tests * Updated based on comments * Updated spacing * Adds apollo fixture for jigsaw tests * Updated to use pvl control network * Switch to using function to compare whole csv lines * Updated to add more individual line comparisons * Updated based on comments * Remove accidentally re-added line * removed ISISROOT path * Remove incorrect comparison part of test * marci2isis test conversion (#4095) * Fix wrong APP_XML * convert to callable app * create tests with cropped data * Initial cropping utilities (#4094) * Initial cropping utilities * Moved notebooks from scripts to notebooks directory * Heldimage + MEstimation tests for jigsaw (#4099) * jigsaw to app conversion and remove unnecessary tests * Updated based on comments * Updated spacing * Adds apollo fixture for jigsaw tests * Updated to use pvl control network * added error tests * started new test * first take * finished mestrimator test * removed things * more merge conflicts Co-authored-by: Kristin <kberry@usgs.gov> * stretch app conversion (#4074) * stretch updates * pull request changes * modified setoutputcube to remove seg fault * merge with dev + fixed bug Co-authored-by: Kelvin <kelvinrr@icloud.com> * Revert "stretch app conversion (#4074)" (#4105) This reverts commit 16d9240. * Mvic App and Test Update (#4102) * Updated mvic app and added the associated tests * Removed old mvic tests * Updated mvic tests with smart pointers for cubes and histograms * Footprintinit Tests (#4077) * Added boundary gtest for footprintinit * Replaced specific path with tempdir path * Updated tests into functional footprintinit tests and ImagePoly unittests * Removed old unit tests * Add outlier test to ImagePolygon test * Removed old test makefiles/folders * Updated tests based on feedback * Removed binary data on mosaic pvl * Adds jigsaw BundleXYZ test (#4101) * jigsaw to app conversion and remove unnecessary tests * Updated based on comments * Updated spacing * Adds apollo fixture for jigsaw tests * Updated to use pvl control network * Switch to using function to compare whole csv lines * Updated to add more individual line comparisons * Updated based on comments * Remove accidentally re-added line * removed ISISROOT path * Remove incorrect comparison part of test * Adds jigsaw BundleXYZ test * chan1m32isis gtest (#4096) * Initial constants unit gtest * Convert chan1m32isis for gtest * Points badfile test to existing product * Refactored for logging * Addresses PR feedback Copies loc/obs files to temp directory Converts hist pointer to smart pointer Removes some unnecessary checks for keys in each test Uses Cube functions instead of label for samples, lines, bands, etc. * Replaced badfile apollo with kaguya * Initial lo2isis test conversion (#4106) * Initial lo2isis test conversion * Initial lo test data * Removed old test makefiles * Converted grid and its tests (#4085) * Refactored grid * Got test to pass * Uncommented deleted pointers * Removed label from nn * Removed functors and added lambda expressions. Got bandDependent test to pass. * Fixed copy/paste error. * Added grid tests * Added grid tests, added leisa cube fixture, and updated default cube fixture to contain image data * Removed log from grid * removed grid tests * Added history entry * forced real DNs in hirise * Changed LEISA cube to use new pointing info * MRO, for REALsies Co-authored-by: Kelvin <kelvinrr@icloud.com> * Cnetextract App and Test Update (#4109) * Convert cnetextract and update tests * Adds a check for bad app inputs * Disabled old tests * Updated cnetextract BadInput test to be three different tests * more jigsaw tests (#4116) * jigsaw to app conversion and remove unnecessary tests * Updated based on comments * Updated spacing * Adds apollo fixture for jigsaw tests * Updated to use pvl control network * added error tests * started new test * first take * finished mestrimator test * removed things * more merge conflicts * added bp tests * new tests * more moerge conflicts * deleted old tests * added rejection test * proper tmp dirs * addressing comments Co-authored-by: Kristin <kberry@usgs.gov> * Added error checking around spicelib furnsh call. Closes #4038 (#4115) * Added error checking around spicelib furnsh call to report error when kernels necessary for calibration where not available. Closes #4038 * Updated for #4038 * added apollocal tests (#4117) * added apollocal tests * added apollocal test * added ap conversions * pointer dumb, now smart * Initial fits2isis gtest conversion (#4114) * Initial fits2isis gtest conversion * Addresses PR feedback * Resolved test failure * Hrsc2isis conversion + gtests (#4121) * Initial hrsc2isis app conversion * Initial hrsc gtests * Ckwriter App and Test Update (#4126) * Convert ckwriter to new app format * Updated ckwriter tests to gtest and fixed angular velocities in the ThreeImageNetwork fixture * Removed old/unnecessary includes * Removed old ckwriter test makefiles * Added Code of Conduct that points to TSC (#4124) * Update qview tools to better support RA/DEC measurements (#4125) * jigsaw to app conversion and remove unnecessary tests * Updated based on comments * Updated spacing * Adds apollo fixture for jigsaw tests * Updated to use pvl control network * Switch to using function to compare whole csv lines * Updated to add more individual line comparisons * Updated based on comments * Remove accidentally re-added line * removed ISISROOT path * Remove incorrect comparison part of test * Adds jigsaw BundleXYZ test * Update qview MeasureTool to add an option to calculate distances using RA/DEC and update qview to show DEC/RA rather than LAT/LON in lower-right corner * Add changelog * Added text to description by Dave Humm. Closes #3860 (#4107) * Added text to description by Dave Humm. Closes #3860 * Forgot to add to the change log file * Update after review * Updated after review * added socetlinescankeywords tests (#4128) * added socetlinescankeywords tests * removed prints * added no blob test * removed prints * addressed comments * removed prefix * Xmlfix (#4134) * Added text to description by Dave Humm. Closes #3860 * Forgot to add to the change log file * Update after review * Updated after review * Fixed broken xmls * Update lronaccal.xml * Shadow App and Test Update (#4118) * Add dn populated dem fixture * Convert the shapow app into the new app format * Translate the base and multiplier from a label * Add dem cube and updated tests * Removed old shadow tests * Fixed demCube fixed label loading * Updated shadow tests and demCube fixture * Lronac2pds App and Test Update (#4135) * Converted lronac2pds to new application format * Updated tests for lronac2pds to gtests * Removed old lronac2pds test makefiles * Removed local path * Addressed PR comments * Hidtmgen conversion + gtests (#4137) * Initial hidtmgen conversion + gtests * Initial hidtmgen tests * Removed compile and deprication warnings. Fixes #4110 * Spkwriter App and Test Update (#4140) * Fixed small bug in spk writer * Converted spkwriter app * Converted tests to Gtests * Removed old tests make files * Removed old spiceinit makefiles and fixed test (#4145) * Removed old spiceinit makefiles and fixed test * Updated spiceinit ck config to use regex for fk * Fixed comment typo * Hicolormos tests (#4133) * converted hicolormos * added colormost things idk * added test * finished tests * removed old tests * mislabeled fixture * missed a spot * more missed sport * removed include * uuuuuuuuuggggh * smaller cube * removed blobs * Removed duplicate inclusion for mappt (#4153) * Removed duplicate inclusion for mappt * Removed exclusion too * Changelog update (#4157) * Fixed changelog and added #4150 * More changelog clean-up * Lronac2isis tests added (#4141) * added new files * added lronac2isis tests * added data (important) * static funcs * Himos App and Test Update (#4156) * Updated himos to new application format * Added new gtests for himos * Removed old himos tests * Addressed excess white spaceing * Added static declaration on app helper functions * Removed unnecessary static declaration * Ringsautomos tests added (#4155) * added ring automos tests * uuuugh * comments * fixed typo * messing up your branchm not even once * Initial demprep conversion + gtests (#4158) * pds2isis gtest (#4144) * write tests with cropped data * add cropped data * test DN's and remove accidental paths * remove accidental prints * fix build failure * remove local path * Update .zenodo.json (#4173) * Updated cropping notebooks to work with pvl 1.0.0 (#4159) * Updated lo_reimported notebooke * Updated kaguya notebook * Updated chan notebook * Changed path * Updated marci notebook * Updated lo notebook * Updated lo notebooks * Added mimap notebook * ApolloPanStitch App and Test Update (#4164) * Updated apollopanstitcher app format * Fixed typo * Updated setoutputcube for ProcessMosaic * Initial stab at the apollopanstitcher gtest * Updated test name * Updated file name * Updated test and removed redundant ui access * Removed old test makefiles * added nocam2map tests (#4167) * added tests * changed include guards to all lower * reduce conversion and gtests (#4174) * inital reduce conversion and gtests * removed comment per PR feedback * Removed log variables in tests. * Automos App and Test Update (#4166) * App conversion for automos * Updated tests for automos * Removed old automos tests * Tested applog output in default test and removed other applog variables * Added north/south pole tests for demprep (#4176) * Added north/south pole tests for demprep * Added missing data files for n/s pole tests. * include changes to main.cpp (#4182) * Std2isis gtests (#4172) * added std2isis tests * removed old tests * added unittests * removed image importer unittest * addressed comments * crism2isis conversion, notebooks, and gtests (#4169) * crism2isis conversion,notebooks, and gtests * Fixed error message typo * Adds 4 new tests * Added missing data * More missing test data * hicubeit gtest (#4188) * app conversion and default case * remove Makefiles * remove appLog parameter * histogram check for each band of output * Bandnorm tests (#4189) * init things * updated tests * removed old tests * address comments * Mapmos test (#4175) * app conversion * add gtest file * add tests * fix mapmos.cpp * remove old tests * include changes to main.cpp * add appLog test and clarify enum location * removed accidental cout * Stretch functional tests (#4154) * stretch updates * pull request changes * modified setoutputcube to remove seg fault * merge with dev + fixed bug * updating test files * modified stretch app * updated mvix * modified setoutputcube functions with null ui parameter * modified stretch test and reverted changes involving setoutputcube * modified setoutputcube function call * made new setoutputcube for stretch * added +1 back to user interface, removed duplicate test * pull request changes Co-authored-by: Kelvin <kelvinrr@icloud.com> * Initial findfeatures app conversion + gtests (#4163) * Initial findfeatures conversion + gtests * Delete makefiles * Addressed PR feedback Removed unnecessary cube.h from findfeatures.h Removed additional cube reopens from threeimagenetwork fixture. Added a comment clarifying empty lat/lon values in match test. * Removed template comment * Removed unused AddFeatures function * Edited test for lat/lon in geomsource * Edited maxpoints test to compare multiple runs of findfeatures * fixed errors (#4202) * Isis2pds App and Gtests (#4198) * Isis2pds App and gtests * Added pds4 conversion test * isis2pds data added * isis2pds Makefiles removed * Added second function with cube parameter and removed unnecessary error checking. * Updated added function with copy/paste error. * Added bypass solution to segfault issue. * Updated isis2pds(ui) function with SetVirtualBands. * Updated isis2pds(ui) function with SetVirtualBands. * Updated isis2pds(ui) function. * Resolved segfault issues. * added camdev tests (#4208) * added camdev tests * tempdir change * prints * mimap2isis app and tests conversion (#4186) * Removed label from nn * Restricted opencv to 3.2 * Refactored mimap2isis * Added ui to setoutputcube * Updated lo_reimported notebooke * Updated kaguya notebook * Updated chan notebook * Changed path * Updated marci notebook * Updated lo notebook * Updated lo notebooks * Added mimap notebook * Added first mimap test * Added gtests and cropped data * Added special pixels test * Renamed image * maptrim app conversion + gtests (#4201) * Maptrim app to function conversion and gtests * Reopen projTestCube to save DNs to cube * Fixed keyword typo * Adjusted automos test histograms to account for DNs * Fixed automos standard deviation * Removed template comment * Removed old makefiles * Converted member vars/funcs to static * Tests that the app log is populated with a mapping group. * Cleaned up cropping notebooks (#4211) Co-authored-by: Adam Paquette <acpaquette@usgs.gov> * Kaguyami App and Test Update (#4190) * Updated kaguyami app to new format * Updated kaguyami2isis tests and added cropped test data * Removed old makefile tests * Updated kaguya cropping notebook to handle bands * Updated kaguya proj test to fail * Convert to callable and add test (#4210) * Convert to callable and add test * removed comment Co-authored-by: Kelvin Rodriguez <kr788@nau.edu> * pointreg app-to-gtest (#4205) * basic app conversion * add test cases * split test cases and address PR review * ThreeImageNetwork already has cube population upstream * address Fixtures.cpp discrepancy * move cube reopens to match in merge conflict * added fixtures Co-authored-by: Kelvin Rodriguez <kr788@nau.edu> Co-authored-by: Kelvin <kelvinrr@icloud.com> * Allows user to use the web service and specify a shape model with spiceinit (#4216) * Allowed web=true and model=user * Added changelog entry * Addressed comments * Ocam warnings added (#4217) * adding warning message to program and documents * pull request review changes * updated warning text Co-authored-by: Jesse Mapel <jam826@nau.edu> * Fixed history entry not being added to a cube when running spiceinit with web=true (#4218) * Caminfo (#4209) * moved main.cpp code into caminfo.cpp * app conversion changes * default test code started * changes to default test 1 * modified default test 1, added name to file * look at all these comparisons * updated csv test * removed print statements * pull request changes Co-authored-by: Kelvin <kelvinrr@icloud.com> * Updated sclk kernel in observation pair fixture pvl files (#4225) * Updated values (#4219) * Jigsaw Target Radii Warning (#4220) * Added warning to jigsaw when solving for the radius of the target body * Updated jigsaw documentation * Updated jigsaw docs based on feedback * Added catch around warning if the target body was not defined (#4229) * ISIS Recipe Changes (#4224) * Updated recipe meta.yaml * Updated build.sh to include jenkins kakadu area * Updated ale version in recipe * Updated ale version in environment.ymls Co-authored-by: Andrew Annex <ama6fy@virginia.edu> Co-authored-by: jlaura <jlaura@usgs.gov> Co-authored-by: Jesse Mapel <jmapel@usgs.gov> Co-authored-by: Kelvin Rodriguez <kr788@nau.edu> Co-authored-by: acpaquette <acpaquette@usgs.gov> Co-authored-by: ssides <ssides@usgs.gov> Co-authored-by: Tim Giroux <62255438+tgiroux@users.noreply.github.com> Co-authored-by: AustinSanders <arsanders@usgs.gov> Co-authored-by: Austin Sanders <arsanders@ugs.gov> Co-authored-by: Ross Beyer <rbeyer@rossbeyer.net> Co-authored-by: Evin Dunn <evindunn14@gmail.com> Co-authored-by: Kelvin <kelvinrr@icloud.com> Co-authored-by: Michael Aye <michaelaye@users.noreply.github.com> Co-authored-by: robotprogrammer22 <46390033+robotprogrammer22@users.noreply.github.com> Co-authored-by: Kaitlyn Lee <kdl222@nau.edu> Co-authored-by: Amy Stamile <74275278+amystamile-usgs@users.noreply.github.com> Co-authored-by: Jesse Mapel <jam826@nau.edu>
kberryUSGS
added a commit
that referenced
this issue
Jan 15, 2021
* Stretch refactor (#3961) * Stretch refactor inital move of Blob out of Stretch and creation of StretchBlob and CubeStretch classes * Cleanup and move setting of name into CubeStretch class * Add ability to save and restore band number associated with stretch (#3963) * Stretch refactor inital move of Blob out of Stretch and creation of StretchBlob and CubeStretch classes * Cleanup and move setting of name into CubeStretch class * Add band numbers initial work * Added the ability to save the band number to the stretch blob and also only list saved stretches with current band number to restore/delete * Moves save/restore/delete of Stretch from AdvancedStretchTool to StretchTool. (#3965) * Stretch refactor inital move of Blob out of Stretch and creation of StretchBlob and CubeStretch classes * Cleanup and move setting of name into CubeStretch class * Add band numbers initial work * Added the ability to save the band number to the stretch blob and also only list saved stretches with current band number to restore/delete * Moves primary save/load/delete to StretchTool from AdvancedStretchTool. Buttons in AdvancedStretchTool work as previously * Stretch refactor (#3966) * Stretch refactor inital move of Blob out of Stretch and creation of StretchBlob and CubeStretch classes * Cleanup and move setting of name into CubeStretch class * Add band numbers initial work * Added the ability to save the band number to the stretch blob and also only list saved stretches with current band number to restore/delete * Moves primary save/load/delete to StretchTool from AdvancedStretchTool. Buttons in AdvancedStretchTool work as previously * Get RGB stretches working, first draft * Add CubeStretch and StretchBlob * Update Blob.cpp Commented the new parameter for Find Co-authored-by: Stuart Sides <ssides@usgs.gov> * Finish up getting RGB to work with Advanced Stretch Tool (#3968) * Stretch refactor inital move of Blob out of Stretch and creation of StretchBlob and CubeStretch classes * Cleanup and move setting of name into CubeStretch class * Add band numbers initial work * Added the ability to save the band number to the stretch blob and also only list saved stretches with current band number to restore/delete * Moves primary save/load/delete to StretchTool from AdvancedStretchTool. Buttons in AdvancedStretchTool work as previously * Get RGB stretches working, first draft * Add CubeStretch and StretchBlob * Update Blob.cpp Commented the new parameter for Find * Update saved stretches for RGB from the advanced stretch tool * Remove couts and cleanup merge * Re-remove save/load/restore buttons from RGB StretchType panels * Update button name from Load to Restore * Remove unused color/grayscale type from StretchBlob output, clean up redundant functions, improve method names Co-authored-by: Stuart Sides <ssides@usgs.gov> * Cleaning up lose ends on Stretch Refactor (#3970) * Stretch refactor inital move of Blob out of Stretch and creation of StretchBlob and CubeStretch classes * Cleanup and move setting of name into CubeStretch class * Add band numbers initial work * Added the ability to save the band number to the stretch blob and also only list saved stretches with current band number to restore/delete * Moves primary save/load/delete to StretchTool from AdvancedStretchTool. Buttons in AdvancedStretchTool work as previously * Get RGB stretches working, first draft * Add CubeStretch and StretchBlob * Update Blob.cpp Commented the new parameter for Find * Update saved stretches for RGB from the advanced stretch tool * Remove couts and cleanup merge * Re-remove save/load/restore buttons from RGB StretchType panels * Update button name from Load to Restore * Remove unused color/grayscale type from StretchBlob output, clean up redundant functions, improve method names * Update button location for AdvancedStretchTool * Switch Blob and Cube Reader filter list from QList<QPair> to QMap * Add documentation to new classes, update to not allow you to select or delete a saved stretch if none exist, and add pop up box for multiband with same band but different stretch no-supported. * Add gtests and delete old-style tests * Add missing StretchBlob test * Update Blob.cpp Co-authored-by: Stuart Sides <ssides@usgs.gov> * Merge Dev into Stretch Feature Branch (#4251) * Update README.md to indicate that isis3VarInit.py is still the script name to use for the current relelase (#3962) * Update README.md * fixed formatting * typo * formatting again * Update based on feedback * add authors checklist item to pr template action item from last ISIS_TC meeting https://github.com/USGS-Astrogeology/ISIS_TC/blob/master/meetings/2020-07-14.md adds a step to the pr template for the author to make sure they add themselves to the authors.rst file * Updates Zenodo (DOI) (#3949) * Updates Zenodo (DOI) The DOI entered will now always resolve tot he newest release. The other DOI was pinned to a specific release. * Updates with a How to Cite section * Review comments addressed * Update README.md * Continuation of updating SpicePosition to use States (#3947) * Initial draft for feedback SpicePosition updated to use States * Added States to SpicePosition and SpiceRotaiton. Removed p_cache and p_velocityCache * Remove debug output and update ReloadCache to use current cache to populate new cache. * Initial updates to SpiceRotation * Update SpicePosition to completely use States for caching position and velocity values * Revert SpiceRotation to dev * Small amount of cleanup * Updated SpicePosition based on feedback * Update SpiceRotation * Update based on comments * fixed cache size * semi-colons * More dumb errors * Fixed bad velocity * Now properly passing cache reduction tolerance * actually reducing cache now * Properly reseting time cache after reduction * More clean up * More careful loading * Testing stuff * Compiling post merge * Fixed test ISDs * updates for unit tests * Fixed cache size check Co-authored-by: Kristin <kberry@usgs.gov> * Reverted change to camsolveAll test * Spice rotation update to use ALE (#3977) Updated SpiceRotation to use ale::Orientations * Create IssueLifecycle.md * Adds a draft .zenodo file to get authors names (#3950) * Adds a draft .zenodo file to get authors names * Updates the contirbuting text to also indicate docs updates needed for first time users * Making the conda recipe work again* (#3986) * changed nn dep * added kakadu incs path * added up to date ale * findale renamed * updated version * removed data vars, added buildTets=OFF * Includes are now packaged in conda builds. (#3989) * changed nn dep * added kakadu incs path * added up to date ale * findale renamed * updated version * removed data vars, added buildTets=OFF * updated scripts * reverted meta * removed commented out line * Added license to conda-build recipe * Update README with details about ISIS Data differences between 4.1 and earlier (#3985) * Update installation instructions * Update README.md * Update README.md * Updated based on feedback * Libisis now installs based on version string (#3992) * libisis3 -> libisis * added simple tests to meta * test stuff * reverty * removed commented out code * added tests : * addressed comments * Added a changelog (#3984) * Empty changelog with versions * Added changelogs from past releases * Updated PR template * Added an audience * Now installs properly * Fixed install paths * Typo fixes * Update file paths for data moved into the $ISISTESTDATA area. (#3991) * Update file paths for unit test-associated data which was moved into the /usgs/cpkgs/isis3/isis_testData area * Move paths for documentation-associated cubes/nets to $ISISDATA/base/examples * Fix incorrect path in comment * update gsl version to fix #3969 (#3993) * update gsl version to fix #3969 updates meta.yaml file to install a more recent version of gsl (>=2.6) * Update environment.yml missed this in initial commit * updated kaguyasp2isis docs to mention deprecation (#3996) * updated kaguyasp2isis docs to mention deprecation * added links * typo * whoops * typo * Updated equalizer output (#4000) * Fixed equalizer output * Added changelog * Added issue number * Stats Docs (#3923) * Updated stats documentation * Updated stats docs based on feedback * isis2raw pure export update (#4002) * Changed check and set range logic/removed duplicate code * Added history comment and moved function outside of if statement * Fixed pixel type prapogation and boolean logic * Addressed PR feedback * Updated the changelog * Add GUI helper to hist so user can see what the minimum and maximum DN values are of the specified band of the cube * Update CHANGELOG.md * changed map2cam to use virtual bands (#4008) * changed map2cam to use virtual bands * changelog * adressing comments * hideal2pds #3978 fix (#3998) * addresses #3978 * corrects for all but 16 bit compression * corrects for all but 16 bit compression organize template files and add 8bit version use 8bit template when 8bit Delete .nfs00000001d83de60d0000003e remove accidental file Updated equalizer output (#4000) * Fixed equalizer output * Added changelog * Added issue number Stats Docs (#3923) * Updated stats documentation * Updated stats docs based on feedback isis2raw pure export update (#4002) * Changed check and set range logic/removed duplicate code * Added history comment and moved function outside of if statement * Fixed pixel type prapogation and boolean logic * Addressed PR feedback * Updated the changelog Add GUI helper to hist so user can see what the minimum and maximum DN values are of the specified band of the cube Update CHANGELOG.md update CHANGELOG and rebase to upstream dev documentation update CHANGELOG and rebase to upstream dev documentation * Updated maptemplate docs (#4009) * changed map2cam to use virtual bands * updated maptemplate docs * typo * changed back to dist being from the center of the target * Added closing table row tag to stats docs (#4016) * FindImageOverlaps test (#4007) * Found old findimageoverlaps test code. Updated based on original PR review * Fix for centos build and other test failures * Added full overlap test and removed old test make files * Simple script to generate AUTHORS.rst from .zenodo.json file (#3995) * Add script to create AUTHORS.rst from .zenodo.json and update AUTHORS.rst * Update PR template and contributing docs * Removed json error in .zenodo.json and update script based on feedback * update based on more feedback * removed comment * Fixed FunctionalTestGetsnAllTrue by creating non-static APP_XML (#4022) * Fixed FunctionalTestGetsnAllTrue by creating non-static APP_XML * Replaced static APP_XML with per-test instances Co-authored-by: Austin Sanders <arsanders@ugs.gov> * zenodo and authors: Upgraded handling of the authors information. (#4024) * docs(zenodo and authors): Upgraded handling of the authors information. - Upgraded zenodo_to_authors.py to write out the AUTHORS.rst file in alphabetical order, and added affiliations, if any. - Created zenodo_order.py to re-arrange the "creator" list in the .zenodo.json file so that it is designated first author (project lead) followed by everyone else in alphabetical order. - Committed the new versions of .zenodo.json and AUTHORS.rst - Added my own name, affiliation, and ORCID iD * feat(zenodo_order.py): Made the first author designation a command line argument with a default, and altered some of the algorithm. * Resolve Test Failure: ThreeImageNetwork.FunctionalTestCnetcheckCamera (SEGFAULT) (#4035) * protect for null vals before SetImage * check for null, not special * Revert reverted histogram PR and handle conflicts. (#4004) * Revert reverted histogram PR and handle conflicts * Added changelog entry * ERROR * local stats fix * Added new ImageHistogram class * Actually added the ImageHistogram class * Made shared variable protected so subclass can access it * Used virtual functions and reverted Cube::histogram to return a Historgram * Added back pipe to dev/null in makefile * Fixes to some app and unit test in the hist PR * More test fixes * Final updates to programs and test data for new histogram calculations * Split the rolls of imagehistogram and histogram * Added and updated unit test truth data * Added the ImageHistogram unittest file * Resolved last comments on hist PR Co-authored-by: Adam Paquette <acpaquette@usgs.gov> * Removes /nomenclature from qisis FeatureNomenclature (#4030) * Moved SpiceRotation unit test to gtest (#4026) * Moved SpiceRotation unit test to gtest * Fixed typo and precision issues * One more precision fix * Removed OS truth data * Review clean-up * Added an ignore line for the new test (#4036) * Modified ALLLIBDIRS to just have paths with no file names. Used for l… (#4031) * Modified ALLLIBDIRS to just have paths with no file names. Used for loader -L option. Closes #3886 * Update CHANGELOG.md * Fixed reference of kakadu library for MacOS * Combined regexs and loops. Added special handling of .so's for MacOS * fixed local pointsstats and imagestats failures (#4042) * Added pre-changelog changes to the changelog These changes were all made prior to taking on our changelog, but I forgot to add them in the initial PR. * Updates labels generated by tgocassisrdrgen and filter information in tgocassis2isis (#4043) * Update filter/filter widths in tgocassis2isis labels * Adds the processing pipeline version to tgo exported labels * Added a sitch browse LID to the label and also updated the psa observation identifier to use the UID * Add new smithed kernel information * Fix tgocassisrdrgen to work on non-Mosaics again * Updated ProcessExportPds4's reorder function to re-order another top-level section: Reference_List * FindImageOverlap optional threaded computation (#4047) * Made the threaded calculation option in findimageoverlaps function call * Fixed type in test file name * Updated change log * Addressed PR feedback * Updated local radius test threshold * Updates dev for the 4.3RC pull/release (#4050) * Updates dev for the 4.3RC pull/release * Updated the changelog for the 4.3.0 RC * Removed manual define of KAKADU_INCLUDE_DIR in build.sh (#4051) * Add gtests for camrange (#4056) * camrange gtest * Update FunctionalTestsCamrange.cpp * Update camrange.h * Update camrange.cpp * remove old tests * Fix wrong APP_XML (#4059) * hicubenorm tests added (#4057) * starting hirise tests * added hirise tests * removed old tests * minor tweaks * updated from comments * now read only * newlines * Update main.cpp Co-authored-by: Stuart Sides <ssides@usgs.gov> * Adds the ability to arbitraily create image polygons from the set of coordinates * hicubenorm fix (#4066) * hicubenorm fix * typo * uuuuuugh, this is what happens when you try to pump out things fast * added Jenkins path to Kakadu * Update 4_Documentation_issue.md (#4068) * Update 4_Documentation_issue.md Change the psychologically disadvantageous emoji for documentation issues. * Update 4_Documentation_issue.md change to GH supported MD * Update 4_Documentation_issue.md had to copy the unicode in for it to render. * leisa2isis gtests (#4062) * Initial leisa tests * Converted leisa tests to gtest * Added raw fits file * fixed names Co-authored-by: Kelvin <kelvinrr@icloud.com> * added hicrop tests (#4072) * added hicrop tests * removed prints * fixed bugs * removed old tests * swapped header funcs * Apollofindrx Test added (#4061) * first run at apollofindrx tests * tests updated * removed old tests * Update FunctionalTestsApolloFindRx.cpp * Update apollofindrx.cpp * Update apollofindrx.h * changes from comments * updated tests with bigger cube * opened window for more cosistant tests and removed a rx point for faster tests * reverted small cube change Co-authored-by: Stuart Sides <ssides@usgs.gov> * Overlapstats test (#4073) * first commit * add all but errortest * remove broken gtest and old tests * rebase and address PR review * first commit * add all but errortest * remove broken gtest and old tests * Jigsaw to app conversion and remove unnecessary tests (#4075) * jigsaw to app conversion and remove unnecessary tests * Updated based on comments * Updated spacing * Remove apollo tests (#4090) * removed apollo tests * removed apollo tests * Jigsaw camsolveall (#4078) * jigsaw to app conversion and remove unnecessary tests * init jigsaw test * prints * prints * all my homies hate control networks * working tests * updated bundleadjust * bin 2 pvl * added csv check, addressed comments * removed header test * renamed to observation * also renamed in fixture * removed old tests Co-authored-by: Kristin <kberry@usgs.gov> * Initial constants unit gtest (#4081) * Initial constants unit gtest * removed old test files * Fixes broken link to astrodiscuss on README.md * Adds apollo fixture (#4080) * jigsaw to app conversion and remove unnecessary tests * Updated based on comments * Updated spacing * Adds apollo fixture for jigsaw tests * Updated to use pvl control network * Updated based on comments * remove accidental jigsaw test commit * Update Jigsaw apollo test based on feedback * Updated botched merge * Remove accidentally updated files * Adding a space to try to trigger Jenkins * added error tests for jigsaw (#4093) * added error tests * added some other error tests * added last test * addressed comments * missed a thing * removed useless test * Converted jigsaw apollo test (#4088) * jigsaw to app conversion and remove unnecessary tests * Updated based on comments * Updated spacing * Adds apollo fixture for jigsaw tests * Updated to use pvl control network * Switch to using function to compare whole csv lines * Updated to add more individual line comparisons * Updated based on comments * Remove accidentally re-added line * removed ISISROOT path * Remove incorrect comparison part of test * marci2isis test conversion (#4095) * Fix wrong APP_XML * convert to callable app * create tests with cropped data * Initial cropping utilities (#4094) * Initial cropping utilities * Moved notebooks from scripts to notebooks directory * Heldimage + MEstimation tests for jigsaw (#4099) * jigsaw to app conversion and remove unnecessary tests * Updated based on comments * Updated spacing * Adds apollo fixture for jigsaw tests * Updated to use pvl control network * added error tests * started new test * first take * finished mestrimator test * removed things * more merge conflicts Co-authored-by: Kristin <kberry@usgs.gov> * stretch app conversion (#4074) * stretch updates * pull request changes * modified setoutputcube to remove seg fault * merge with dev + fixed bug Co-authored-by: Kelvin <kelvinrr@icloud.com> * Revert "stretch app conversion (#4074)" (#4105) This reverts commit 16d9240. * Mvic App and Test Update (#4102) * Updated mvic app and added the associated tests * Removed old mvic tests * Updated mvic tests with smart pointers for cubes and histograms * Footprintinit Tests (#4077) * Added boundary gtest for footprintinit * Replaced specific path with tempdir path * Updated tests into functional footprintinit tests and ImagePoly unittests * Removed old unit tests * Add outlier test to ImagePolygon test * Removed old test makefiles/folders * Updated tests based on feedback * Removed binary data on mosaic pvl * Adds jigsaw BundleXYZ test (#4101) * jigsaw to app conversion and remove unnecessary tests * Updated based on comments * Updated spacing * Adds apollo fixture for jigsaw tests * Updated to use pvl control network * Switch to using function to compare whole csv lines * Updated to add more individual line comparisons * Updated based on comments * Remove accidentally re-added line * removed ISISROOT path * Remove incorrect comparison part of test * Adds jigsaw BundleXYZ test * chan1m32isis gtest (#4096) * Initial constants unit gtest * Convert chan1m32isis for gtest * Points badfile test to existing product * Refactored for logging * Addresses PR feedback Copies loc/obs files to temp directory Converts hist pointer to smart pointer Removes some unnecessary checks for keys in each test Uses Cube functions instead of label for samples, lines, bands, etc. * Replaced badfile apollo with kaguya * Initial lo2isis test conversion (#4106) * Initial lo2isis test conversion * Initial lo test data * Removed old test makefiles * Converted grid and its tests (#4085) * Refactored grid * Got test to pass * Uncommented deleted pointers * Removed label from nn * Removed functors and added lambda expressions. Got bandDependent test to pass. * Fixed copy/paste error. * Added grid tests * Added grid tests, added leisa cube fixture, and updated default cube fixture to contain image data * Removed log from grid * removed grid tests * Added history entry * forced real DNs in hirise * Changed LEISA cube to use new pointing info * MRO, for REALsies Co-authored-by: Kelvin <kelvinrr@icloud.com> * Cnetextract App and Test Update (#4109) * Convert cnetextract and update tests * Adds a check for bad app inputs * Disabled old tests * Updated cnetextract BadInput test to be three different tests * more jigsaw tests (#4116) * jigsaw to app conversion and remove unnecessary tests * Updated based on comments * Updated spacing * Adds apollo fixture for jigsaw tests * Updated to use pvl control network * added error tests * started new test * first take * finished mestrimator test * removed things * more merge conflicts * added bp tests * new tests * more moerge conflicts * deleted old tests * added rejection test * proper tmp dirs * addressing comments Co-authored-by: Kristin <kberry@usgs.gov> * Added error checking around spicelib furnsh call. Closes #4038 (#4115) * Added error checking around spicelib furnsh call to report error when kernels necessary for calibration where not available. Closes #4038 * Updated for #4038 * added apollocal tests (#4117) * added apollocal tests * added apollocal test * added ap conversions * pointer dumb, now smart * Initial fits2isis gtest conversion (#4114) * Initial fits2isis gtest conversion * Addresses PR feedback * Resolved test failure * Hrsc2isis conversion + gtests (#4121) * Initial hrsc2isis app conversion * Initial hrsc gtests * Ckwriter App and Test Update (#4126) * Convert ckwriter to new app format * Updated ckwriter tests to gtest and fixed angular velocities in the ThreeImageNetwork fixture * Removed old/unnecessary includes * Removed old ckwriter test makefiles * Added Code of Conduct that points to TSC (#4124) * Update qview tools to better support RA/DEC measurements (#4125) * jigsaw to app conversion and remove unnecessary tests * Updated based on comments * Updated spacing * Adds apollo fixture for jigsaw tests * Updated to use pvl control network * Switch to using function to compare whole csv lines * Updated to add more individual line comparisons * Updated based on comments * Remove accidentally re-added line * removed ISISROOT path * Remove incorrect comparison part of test * Adds jigsaw BundleXYZ test * Update qview MeasureTool to add an option to calculate distances using RA/DEC and update qview to show DEC/RA rather than LAT/LON in lower-right corner * Add changelog * Added text to description by Dave Humm. Closes #3860 (#4107) * Added text to description by Dave Humm. Closes #3860 * Forgot to add to the change log file * Update after review * Updated after review * added socetlinescankeywords tests (#4128) * added socetlinescankeywords tests * removed prints * added no blob test * removed prints * addressed comments * removed prefix * Xmlfix (#4134) * Added text to description by Dave Humm. Closes #3860 * Forgot to add to the change log file * Update after review * Updated after review * Fixed broken xmls * Update lronaccal.xml * Shadow App and Test Update (#4118) * Add dn populated dem fixture * Convert the shapow app into the new app format * Translate the base and multiplier from a label * Add dem cube and updated tests * Removed old shadow tests * Fixed demCube fixed label loading * Updated shadow tests and demCube fixture * Lronac2pds App and Test Update (#4135) * Converted lronac2pds to new application format * Updated tests for lronac2pds to gtests * Removed old lronac2pds test makefiles * Removed local path * Addressed PR comments * Hidtmgen conversion + gtests (#4137) * Initial hidtmgen conversion + gtests * Initial hidtmgen tests * Removed compile and deprication warnings. Fixes #4110 * Spkwriter App and Test Update (#4140) * Fixed small bug in spk writer * Converted spkwriter app * Converted tests to Gtests * Removed old tests make files * Removed old spiceinit makefiles and fixed test (#4145) * Removed old spiceinit makefiles and fixed test * Updated spiceinit ck config to use regex for fk * Fixed comment typo * Hicolormos tests (#4133) * converted hicolormos * added colormost things idk * added test * finished tests * removed old tests * mislabeled fixture * missed a spot * more missed sport * removed include * uuuuuuuuuggggh * smaller cube * removed blobs * Removed duplicate inclusion for mappt (#4153) * Removed duplicate inclusion for mappt * Removed exclusion too * Changelog update (#4157) * Fixed changelog and added #4150 * More changelog clean-up * Lronac2isis tests added (#4141) * added new files * added lronac2isis tests * added data (important) * static funcs * Himos App and Test Update (#4156) * Updated himos to new application format * Added new gtests for himos * Removed old himos tests * Addressed excess white spaceing * Added static declaration on app helper functions * Removed unnecessary static declaration * Ringsautomos tests added (#4155) * added ring automos tests * uuuugh * comments * fixed typo * messing up your branchm not even once * Initial demprep conversion + gtests (#4158) * pds2isis gtest (#4144) * write tests with cropped data * add cropped data * test DN's and remove accidental paths * remove accidental prints * fix build failure * remove local path * Update .zenodo.json (#4173) * Updated cropping notebooks to work with pvl 1.0.0 (#4159) * Updated lo_reimported notebooke * Updated kaguya notebook * Updated chan notebook * Changed path * Updated marci notebook * Updated lo notebook * Updated lo notebooks * Added mimap notebook * ApolloPanStitch App and Test Update (#4164) * Updated apollopanstitcher app format * Fixed typo * Updated setoutputcube for ProcessMosaic * Initial stab at the apollopanstitcher gtest * Updated test name * Updated file name * Updated test and removed redundant ui access * Removed old test makefiles * added nocam2map tests (#4167) * added tests * changed include guards to all lower * reduce conversion and gtests (#4174) * inital reduce conversion and gtests * removed comment per PR feedback * Removed log variables in tests. * Automos App and Test Update (#4166) * App conversion for automos * Updated tests for automos * Removed old automos tests * Tested applog output in default test and removed other applog variables * Added north/south pole tests for demprep (#4176) * Added north/south pole tests for demprep * Added missing data files for n/s pole tests. * include changes to main.cpp (#4182) * Std2isis gtests (#4172) * added std2isis tests * removed old tests * added unittests * removed image importer unittest * addressed comments * crism2isis conversion, notebooks, and gtests (#4169) * crism2isis conversion,notebooks, and gtests * Fixed error message typo * Adds 4 new tests * Added missing data * More missing test data * hicubeit gtest (#4188) * app conversion and default case * remove Makefiles * remove appLog parameter * histogram check for each band of output * Bandnorm tests (#4189) * init things * updated tests * removed old tests * address comments * Mapmos test (#4175) * app conversion * add gtest file * add tests * fix mapmos.cpp * remove old tests * include changes to main.cpp * add appLog test and clarify enum location * removed accidental cout * Stretch functional tests (#4154) * stretch updates * pull request changes * modified setoutputcube to remove seg fault * merge with dev + fixed bug * updating test files * modified stretch app * updated mvix * modified setoutputcube functions with null ui parameter * modified stretch test and reverted changes involving setoutputcube * modified setoutputcube function call * made new setoutputcube for stretch * added +1 back to user interface, removed duplicate test * pull request changes Co-authored-by: Kelvin <kelvinrr@icloud.com> * Initial findfeatures app conversion + gtests (#4163) * Initial findfeatures conversion + gtests * Delete makefiles * Addressed PR feedback Removed unnecessary cube.h from findfeatures.h Removed additional cube reopens from threeimagenetwork fixture. Added a comment clarifying empty lat/lon values in match test. * Removed template comment * Removed unused AddFeatures function * Edited test for lat/lon in geomsource * Edited maxpoints test to compare multiple runs of findfeatures * fixed errors (#4202) * Isis2pds App and Gtests (#4198) * Isis2pds App and gtests * Added pds4 conversion test * isis2pds data added * isis2pds Makefiles removed * Added second function with cube parameter and removed unnecessary error checking. * Updated added function with copy/paste error. * Added bypass solution to segfault issue. * Updated isis2pds(ui) function with SetVirtualBands. * Updated isis2pds(ui) function with SetVirtualBands. * Updated isis2pds(ui) function. * Resolved segfault issues. * added camdev tests (#4208) * added camdev tests * tempdir change * prints * mimap2isis app and tests conversion (#4186) * Removed label from nn * Restricted opencv to 3.2 * Refactored mimap2isis * Added ui to setoutputcube * Updated lo_reimported notebooke * Updated kaguya notebook * Updated chan notebook * Changed path * Updated marci notebook * Updated lo notebook * Updated lo notebooks * Added mimap notebook * Added first mimap test * Added gtests and cropped data * Added special pixels test * Renamed image * maptrim app conversion + gtests (#4201) * Maptrim app to function conversion and gtests * Reopen projTestCube to save DNs to cube * Fixed keyword typo * Adjusted automos test histograms to account for DNs * Fixed automos standard deviation * Removed template comment * Removed old makefiles * Converted member vars/funcs to static * Tests that the app log is populated with a mapping group. * Cleaned up cropping notebooks (#4211) Co-authored-by: Adam Paquette <acpaquette@usgs.gov> * Kaguyami App and Test Update (#4190) * Updated kaguyami app to new format * Updated kaguyami2isis tests and added cropped test data * Removed old makefile tests * Updated kaguya cropping notebook to handle bands * Updated kaguya proj test to fail * Convert to callable and add test (#4210) * Convert to callable and add test * removed comment Co-authored-by: Kelvin Rodriguez <kr788@nau.edu> * pointreg app-to-gtest (#4205) * basic app conversion * add test cases * split test cases and address PR review * ThreeImageNetwork already has cube population upstream * address Fixtures.cpp discrepancy * move cube reopens to match in merge conflict * added fixtures Co-authored-by: Kelvin Rodriguez <kr788@nau.edu> Co-authored-by: Kelvin <kelvinrr@icloud.com> * Allows user to use the web service and specify a shape model with spiceinit (#4216) * Allowed web=true and model=user * Added changelog entry * Addressed comments * Ocam warnings added (#4217) * adding warning message to program and documents * pull request review changes * updated warning text Co-authored-by: Jesse Mapel <jam826@nau.edu> * Fixed history entry not being added to a cube when running spiceinit with web=true (#4218) * Caminfo (#4209) * moved main.cpp code into caminfo.cpp * app conversion changes * default test code started * changes to default test 1 * modified default test 1, added name to file * look at all these comparisons * updated csv test * removed print statements * pull request changes Co-authored-by: Kelvin <kelvinrr@icloud.com> * Updated sclk kernel in observation pair fixture pvl files (#4225) * Updated values (#4219) * Jigsaw Target Radii Warning (#4220) * Added warning to jigsaw when solving for the radius of the target body * Updated jigsaw documentation * Updated jigsaw docs based on feedback * Added catch around warning if the target body was not defined (#4229) * ISIS Recipe Changes (#4224) * Updated recipe meta.yaml * Updated build.sh to include jenkins kakadu area * Updated ale version in recipe * Updated ale version in environment.ymls Co-authored-by: Andrew Annex <ama6fy@virginia.edu> Co-authored-by: jlaura <jlaura@usgs.gov> Co-authored-by: Jesse Mapel <jmapel@usgs.gov> Co-authored-by: Kelvin Rodriguez <kr788@nau.edu> Co-authored-by: acpaquette <acpaquette@usgs.gov> Co-authored-by: ssides <ssides@usgs.gov> Co-authored-by: Tim Giroux <62255438+tgiroux@users.noreply.github.com> Co-authored-by: AustinSanders <arsanders@usgs.gov> Co-authored-by: Austin Sanders <arsanders@ugs.gov> Co-authored-by: Ross Beyer <rbeyer@rossbeyer.net> Co-authored-by: Evin Dunn <evindunn14@gmail.com> Co-authored-by: Kelvin <kelvinrr@icloud.com> Co-authored-by: Michael Aye <michaelaye@users.noreply.github.com> Co-authored-by: robotprogrammer22 <46390033+robotprogrammer22@users.noreply.github.com> Co-authored-by: Kaitlyn Lee <kdl222@nau.edu> Co-authored-by: Amy Stamile <74275278+amystamile-usgs@users.noreply.github.com> Co-authored-by: Jesse Mapel <jam826@nau.edu> * Revert "Merge Dev into Stretch Feature Branch (#4251)" (#4252) This reverts commit daec78c. * Update stretch branch based on PR review (#4253) * Update to use CubeStretches were appropriate and other updates based on PR review * Further updates based on review and added tests based on minor problems uncovered and fixed * Removed commented-out code * Stretch tool updates based on error message popping up inappropriately * Updated setting of member variable * Fix but in which special pixel values selected by the Special Pixel tool or defaults were not applied to restored stretches Co-authored-by: Stuart Sides <ssides@usgs.gov> Co-authored-by: Andrew Annex <ama6fy@virginia.edu> Co-authored-by: jlaura <jlaura@usgs.gov> Co-authored-by: Jesse Mapel <jmapel@usgs.gov> Co-authored-by: Kelvin Rodriguez <kr788@nau.edu> Co-authored-by: acpaquette <acpaquette@usgs.gov> Co-authored-by: Tim Giroux <62255438+tgiroux@users.noreply.github.com> Co-authored-by: AustinSanders <arsanders@usgs.gov> Co-authored-by: Austin Sanders <arsanders@ugs.gov> Co-authored-by: Ross Beyer <rbeyer@rossbeyer.net> Co-authored-by: Evin Dunn <evindunn14@gmail.com> Co-authored-by: Kelvin <kelvinrr@icloud.com> Co-authored-by: Michael Aye <michaelaye@users.noreply.github.com> Co-authored-by: robotprogrammer22 <46390033+robotprogrammer22@users.noreply.github.com> Co-authored-by: Kaitlyn Lee <kdl222@nau.edu> Co-authored-by: Amy Stamile <74275278+amystamile-usgs@users.noreply.github.com> Co-authored-by: Jesse Mapel <jam826@nau.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ISIS version(s) affected: 3.10.1 and 4.1.0 on MacOS 10.14.6, and 3.12.0 on a different MacOS 10.14.6 system.
EDIT: Just updated the 4.1.0 install to 4.2.0. The issue persists.
EDIT: The "3.12.0" was probably 4.something, with the version edited to say "3.12.0" as a work-around for a web SPICE error, per #3725 (comment). Ben Bussey may have more detail- it's his system.
Description
When running a LROC WAC image through lrowaccal on MacOS, the. output values all end up as 0.0. The exact same processing steps on ISIS 3.9.1 and 4.1.0 on Linux produce a properly-calibrated image. All the calibration files listed in the Radiometry groups are identical (same MD5 checksum) between the two systems, so I suspect it's the executable file that's the problem.
How to reproduce
wget http://pds.lroc.asu.edu/data/LRO-L-LROC-2-EDR-V1.0/LROLRC_0027/DATA/ESM2/2016163/WAC/M1220245217CE.IMG
lrowac2isis from=M1220245217CE.IMG to=M1220245217CE
lrowaccal from=M1220245217CE.vis.even.cub to=M1220245217CE.vis.even.cal.cub
UPDATE:
Skipping the radiometric calibration step causes the output to stop being 0, so that's probably where the problem is:
lrowaccal from=M1220245217CE.vis.even.cub+1 to=M1220245217CE.vis.even.cal.cub Radiometric=false
The text was updated successfully, but these errors were encountered: