Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine existing import/export applications #4606

Closed
scsides opened this issue Aug 24, 2021 · 4 comments
Closed

Combine existing import/export applications #4606

scsides opened this issue Aug 24, 2021 · 4 comments
Assignees
Labels
enhancement New feature or request inactive Issue that has been inactive for at least 6 months RFC

Comments

@scsides
Copy link
Contributor

scsides commented Aug 24, 2021

Description
Combine existing import/export apps into one import, and one export app

Place all comments regarding RFC 7 - Redesign Import Export programs in this issue

Example
isisimport from=tgocassis.img to=tgocassis.cub
isisexport from=tgocassis.cub to=tgocassisrdr

@scsides scsides added the RFC label Aug 24, 2021
@scsides scsides self-assigned this Aug 24, 2021
@lwellerastro
Copy link
Contributor

  • Users will be able to modify templates without recompiling ISIS

Will every camera have a template covering all of the current keywords currently translated? As you know missions do not tend to use the same keywords for identical information and there are always those mission specific keywords.

Will templates be available under the data area to point to and modify if there are keywords of interest missing?

What about those handful of ingestion programs (kaguyatc2isis being one) that has parameters beyond from and to?

It would be helpful to see specific examples when they become available.

I'm sure I'll have more questions in the future as I don't fully understand the scope of what's laid out in the RFC.

@scsides
Copy link
Contributor Author

scsides commented Sep 21, 2021

  • Users will be able to modify templates without recompiling ISIS

Will every camera have a template covering all of the current keywords currently translated? As you know missions do not tend to use the same keywords for identical information and there are always those mission specific keywords.

Because of the reasons you listed we expect each camera to have its own template. Some may be able to be combined, but we plan to do that only if they are identical or can be easily tweaked using the template capabilities.

Will templates be available under the data area to point to and modify if there are keywords of interest missing?

All of the templates will be distributed with ISIS. The current thinking is that if someone wants to use their own or a modified version of the one in ISIS, all they would have to do is supply the new template file name on the command line. This would override the automatic template name.

What about those handful of ingestion programs (kaguyatc2isis being one) that has parameters beyond from and to?

There are plans to allow some keywords that are used regularly to be overridden (e.g., TargeName). More complex apps may not be able to be converted to this method.

It would be helpful to see specific examples when they become available.
There is one for tgo now in the system (appdata/import and appdata/export)

I'm sure I'll have more questions in the future as I don't fully understand the scope of what's laid out in the RFC.

@github-actions
Copy link

Thank you for your contribution!

Unfortunately, this issue hasn't received much attention lately, so it is labeled as 'stale.'

If no additional action is taken, this issue will be automatically closed in 180 days.

@github-actions github-actions bot added the inactive Issue that has been inactive for at least 6 months label Mar 21, 2022
@scsides scsides added enhancement New feature or request and removed inactive Issue that has been inactive for at least 6 months labels Mar 21, 2022
@github-actions
Copy link

Thank you for your contribution!

Unfortunately, this issue hasn't received much attention lately, so it is labeled as 'stale.'

If no additional action is taken, this issue will be automatically closed in 180 days.

@github-actions github-actions bot added the inactive Issue that has been inactive for at least 6 months label Sep 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request inactive Issue that has been inactive for at least 6 months RFC
Projects
None yet
Development

No branches or pull requests

2 participants