Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor isisminer to be callable and migrate Makefile tests to gtest format #5516

Closed
kledmundson opened this issue Jun 6, 2024 · 0 comments
Closed

Refactor isisminer to be callable and migrate Makefile tests to gtest format #5516

kledmundson opened this issue Jun 6, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@kledmundson
Copy link
Contributor

Description

The isisminer application needs to be refactored to be callable. Makefile tests need to be replaced with gtests.
@kledmundson kledmundson added the enhancement New feature or request label Jun 6, 2024
kledmundson added a commit to kledmundson/ISIS3 that referenced this issue Jul 16, 2024
@kledmundson
Fixed minor misspellings in error messages. Addresses DOI-USGS#5516.
2b08bbb
kledmundson added a commit to kledmundson/ISIS3 that referenced this issue Jul 16, 2024
@kledmundson
Test data added for isisminer. Addresses DOI-USGS#5516.
2eead64
kledmundson added a commit to kledmundson/ISIS3 that referenced this issue Jul 16, 2024
@kledmundson
Converted isisminer Makefile tests to gtest format. Addresses DOI-USG…
21e5154 
…S#5516.
kledmundson added a commit to kledmundson/ISIS3 that referenced this issue Jul 16, 2024
@kledmundson
Converted isisminer application to callable function. Addresses DOI-U…
4dfe585 
…SGS#5516.
kledmundson added a commit to kledmundson/ISIS3 that referenced this issue Jul 16, 2024
@kledmundson
Minor tweak to isisminer csvwriter test. Addresses DOI-USGS#5516.
b3e574b
kledmundson added a commit to kledmundson/ISIS3 that referenced this issue Jul 16, 2024
@kledmundson
Added compareCsvLineCustomDelimiter method, specifically for isismine…
5b05740 
…r testing support. Addresses DOI-USGS#5516.
kledmundson added a commit to kledmundson/ISIS3 that referenced this issue Jul 16, 2024
@kledmundson
Removed isisminer Makefile tests (replaced by gtests) and updated CHA…
5e9ddb5 
…NGELOG reflecting conversion of isisminer to callable app. Addresses DOI-USGS#5516.
kledmundson added a commit to UA-LPL/ISIS3 that referenced this issue Aug 7, 2024
@kledmundson
Fixed minor misspellings in error messages. Addresses DOI-USGS#5516.
ba2c5ad
kledmundson added a commit to UA-LPL/ISIS3 that referenced this issue Aug 7, 2024
@kledmundson
Test data added for isisminer. Addresses DOI-USGS#5516.
3222df5
kledmundson added a commit to UA-LPL/ISIS3 that referenced this issue Aug 7, 2024
@kledmundson
Converted isisminer Makefile tests to gtest format. Addresses DOI-USG…
201e5bd 
…S#5516.
kledmundson added a commit to UA-LPL/ISIS3 that referenced this issue Aug 7, 2024
@kledmundson
Converted isisminer application to callable function. Addresses DOI-U…
96637c7 
…SGS#5516.
kledmundson added a commit to UA-LPL/ISIS3 that referenced this issue Aug 7, 2024
@kledmundson
Minor tweak to isisminer csvwriter test. Addresses DOI-USGS#5516.
6a46568
kledmundson added a commit to UA-LPL/ISIS3 that referenced this issue Aug 7, 2024
@kledmundson
Added compareCsvLineCustomDelimiter method, specifically for isismine…
210c82c 
…r testing support. Addresses DOI-USGS#5516.
kledmundson added a commit to UA-LPL/ISIS3 that referenced this issue Aug 7, 2024
@kledmundson
Removed isisminer Makefile tests (replaced by gtests) and updated CHA…
c75d33b 
…NGELOG reflecting conversion of isisminer to callable app. Addresses DOI-USGS#5516.
kledmundson added a commit to UA-LPL/ISIS3 that referenced this issue Aug 7, 2024
@kledmundson
Replace isis cube in /isis/tests/data/isisminer/gistest with isd and …
72c6506 
…label files. Minor tweaks to FunctionalTestsIsisminer.cpp. History entry added to isisminer.xml. Addresses DOI-USGS#5516.
kledmundson added a commit to UA-LPL/ISIS3 that referenced this issue Aug 7, 2024
@kledmundson
Minor changes for conversion of isisminer to callable app. Addresses D…
75bc31f 
…OI-USGS#5516.
@kledmundson kledmundson mentioned this issue Aug 7, 2024
Merged
12 tasks
kledmundson added a commit to UA-LPL/ISIS3 that referenced this issue Aug 27, 2024
@kledmundson
Had to add data file index.lbl to the .gitignore file for it to be up…
f22eb04 
…loaded. Addresses DOI-USGS#5516.
acpaquette pushed a commit that referenced this issue Sep 11, 2024
@kledmundson
Isisminer has been refactored to be callable and Makefile tests conve…
c6b5df4 
…rted to gtest format (#5579)

* Fixed minor misspellings in error messages. Addresses #5516.

* Test data added for isisminer. Addresses #5516.

* Converted isisminer Makefile tests to gtest format. Addresses #5516.

* Converted isisminer application to callable function. Addresses #5516.

* Minor tweak to isisminer csvwriter test. Addresses #5516.

* Added compareCsvLineCustomDelimiter method, specifically for isisminer testing support. Addresses #5516.

* Removed isisminer Makefile tests (replaced by gtests) and updated CHANGELOG reflecting conversion of isisminer to callable app. Addresses #5516.

* Replace isis cube in /isis/tests/data/isisminer/gistest with isd and label files. Minor tweaks to FunctionalTestsIsisminer.cpp. History entry added to isisminer.xml. Addresses #5516.

* Minor changes for conversion of isisminer to callable app. Addresses #5516.

* Had to add data file index.lbl to the .gitignore file for it to be uploaded. Addresses #5516.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
Astro Software Support Sprint
Status: Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kledmundson @amystamile-usgs @jrcain-usgs