Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version dropdown and dev links #4872

Merged
merged 2 commits into from
Apr 11, 2022
Merged

Conversation

scsides
Copy link
Contributor

@scsides scsides commented Mar 21, 2022

Add a dropdown for the version of docs to view

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation change (update to the documentation; no code change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have read and agree to abide by the Code of Conduct
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have added myself to the .zenodo.json document.
  • I have added any user impacting changes to the CHANGELOG.md document.

Licensing

This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words:

This work is free and unencumbered software released into the public domain. In jurisdictions that recognize copyright laws, the author or authors of this software dedicate any and all copyright interest in the software to the public domain.

  • I dedicate any and all copyright interest in this software to the public domain. I make this dedication for the benefit of the public at large and to the detriment of my heirs and successors. I intend this dedication to be an overt act of relinquishment in perpetuity of all present and future rights to this software under copyright law.

@@ -170,7 +170,7 @@ Deborah Lee Soltesz
</tr>
<tr valign="top">
<th style="width:25%">
<a href="">
<a href="../documents/DeveloperModifyIsis/DeveloperModifyIsis.html">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am making a note, cause I almost got confused. This file is in the #4871 PR

Copy link
Contributor Author

@scsides scsides Mar 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it is. These docs won't build without both PRs

@ladoramkershner
Copy link
Contributor

I think this is a really good solution. Did you want to do more work to homogenize the style before merging?

@scsides
Copy link
Contributor Author

scsides commented Mar 22, 2022

I think this is a really good solution. Did you want to do more work to homogenize the style before merging?

I think this is good for now. It can get more styling later.

@ladoramkershner ladoramkershner merged commit 2334703 into DOI-USGS:dev Apr 11, 2022
jessemapel pushed a commit to jessemapel/ISIS3 that referenced this pull request Apr 14, 2022
* Version dropdown and dev links

* Fixed link
jessemapel pushed a commit that referenced this pull request Apr 14, 2022
* Version dropdown and dev links

* Fixed link
@jessemapel jessemapel mentioned this pull request Apr 14, 2022
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants