Re-add and refactor lrowacphomap #4961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add radiance units label in lrowaccal output cube
Revert "Add radiance units label in lrowaccal output cube"
|
Working on the review. I'll start a CI test for this as well. |
|
While I'm finishing the review, you might want to check out the test failure: https://astroservices.usgs.gov/jenkins/job/USGS-Astrogeology/job/ISIS3/view/change-requests/job/PR-4961/2/execution/node/31/log/?consoleFull Scroll to the bottom to see the error, then search for the error number, or just search for the program or test name |
…label to relative path
… updated ShapeModel value
|
These new commits should solve the Lrowacphomap.FunctionalTestLrowacphomapNoBack failure. |
|
The failure for 2030 - TestKernelDb.TestKernelsSmithOffset (Failed) is not from this PR so disregard for now |
scsides
approved these changes
May 25, 2022
|
CI ran without errors caused by this. Merged |
Kelvinrr
pushed a commit
to gsn9/ISIS3
that referenced
this pull request
Jul 18, 2022
* Add radiance units label in lrowaccal output cube * Revert "Add radiance units label in lrowaccal output cube" * Add refactored lrowacphomap app * Add lrowacphomap functional tests and test data * Add entry to CHANGELOG.md for the re-addition and refactoring of lrowacphomap * Change ShapeModel keyword in Kernels group of lrowacphomap test cube label to relative path * Add new test cube corresponding to the lrowacphomap test input cube's updated ShapeModel value * Update expected stats result values for the LrowacphomapNoBack functional test Co-authored-by: Victor Silva <victor.silva@asu.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
#4960
Motivation and Context
This change enables applying photometric correction to WAC cubes with a parameter cube defining Hapke model parameters for the correction, a PVL file defining the algorithm, and an optional backplane cube.
This change also brings lrowacphomap in line with the newer testing framework for ISIS and covers the re-addition and refactoring with functional tests.
How Has This Been Tested?
Functional tests were added to
isis/tests/FunctionalTestsLrowacphomap.cppto cover the re-addition by validating its output.The app was also tested and validated by the science team at LROC.
Screenshots (if appropriate):
Types of changes
Checklist:
Licensing
This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words: