Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slicing with 0% support density does not terminate if the cross pattern is used. #1412

Closed
ThomasRahm opened this issue Feb 12, 2021 · 4 comments
Labels
Status: Deferred Not for now, but we could find the time or need to do this later. Type: Bug

Comments

@ThomasRahm
Copy link
Contributor

Application Version
4.7.1

Platform
Windows 10

Steps to Reproduce
Set Support Pattern to "cross" and Support Density to 0% with support enabled.

Actual Results
The slicing never finishes.

Expected results
The support should have no infill.

Additional Information
Issue is that support line distance is set to 0 when the support density is 0.
This causes the following loop of SierpinskiFillProvider.cpp (line 73) to never terminate:

coord_t aabb_size = min_line_distance;
while (aabb_size < max_side_length)
{
    aabb_size *= 2;
    depth += 2;
}

As aabb_size will be 0.

I am not sure how to fix this issue, without potentially adding a new one.

@fvrmr
Copy link

fvrmr commented Feb 18, 2021

Hi @ThomasRahm thank you for your report.
I can also reproduce this in 4.8. I will discuss it with the team.
Keep you posted!

@fvrmr
Copy link

fvrmr commented Feb 19, 2021

Hi @ThomasRahm I have discussed it with the team. But I have to defer this. Because it is really exceptional to run into this. So it is not a priority for us to fix. Hope you understand.

@fvrmr fvrmr added Type: Bug Status: Deferred Not for now, but we could find the time or need to do this later. labels Feb 19, 2021
@lospo
Copy link

lospo commented May 23, 2022

Hi thomas, this is not a bug!
I've talked about your mod, maybe you are interested!
https://community.ultimaker.com/topic/40567-cura-tree-support-mod-ts2/
Have a good day

@ThomasRahm
Copy link
Contributor Author

@lospo Great to hear that you like it, but this is the wrong place for it.
If you want to give feedback here on github, please use the draft pull-request thread for it.
Also you may want to edit your message, as i interpreted "This is not a bug" as disagreeing regarding the bug reported above and that the slicing to hang is intentional.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Deferred Not for now, but we could find the time or need to do this later. Type: Bug
Projects
None yet
Development

No branches or pull requests

3 participants