From ee9423ad577e0a7d4cf6706a8fd91654bf2b7f03 Mon Sep 17 00:00:00 2001 From: Eric Zhong Date: Wed, 6 Dec 2023 11:11:09 -0500 Subject: [PATCH] remove constructor param (#13) --- .../RelayOrderReactorIntegrationTest-testExecute.snap | 2 +- ...ReactorIntegrationTest-testExecuteWithNativeAsOutput.snap | 2 +- ...elayOrderReactorIntegrationTest-testPermitAndExecute.snap | 2 +- src/reactors/RelayOrderReactor.sol | 5 +---- .../integration/RelayOrderReactorIntegration.t.sol | 2 +- 5 files changed, 5 insertions(+), 8 deletions(-) diff --git a/.forge-snapshots/RelayOrderReactorIntegrationTest-testExecute.snap b/.forge-snapshots/RelayOrderReactorIntegrationTest-testExecute.snap index 2175a16a..37fbf6d2 100644 --- a/.forge-snapshots/RelayOrderReactorIntegrationTest-testExecute.snap +++ b/.forge-snapshots/RelayOrderReactorIntegrationTest-testExecute.snap @@ -1 +1 @@ -254368 \ No newline at end of file +254346 \ No newline at end of file diff --git a/.forge-snapshots/RelayOrderReactorIntegrationTest-testExecuteWithNativeAsOutput.snap b/.forge-snapshots/RelayOrderReactorIntegrationTest-testExecuteWithNativeAsOutput.snap index e8c58f56..f1743f2f 100644 --- a/.forge-snapshots/RelayOrderReactorIntegrationTest-testExecuteWithNativeAsOutput.snap +++ b/.forge-snapshots/RelayOrderReactorIntegrationTest-testExecuteWithNativeAsOutput.snap @@ -1 +1 @@ -280732 \ No newline at end of file +280710 \ No newline at end of file diff --git a/.forge-snapshots/RelayOrderReactorIntegrationTest-testPermitAndExecute.snap b/.forge-snapshots/RelayOrderReactorIntegrationTest-testPermitAndExecute.snap index 003e4e86..cb9d3a56 100644 --- a/.forge-snapshots/RelayOrderReactorIntegrationTest-testPermitAndExecute.snap +++ b/.forge-snapshots/RelayOrderReactorIntegrationTest-testPermitAndExecute.snap @@ -1 +1 @@ -310437 \ No newline at end of file +310415 \ No newline at end of file diff --git a/src/reactors/RelayOrderReactor.sol b/src/reactors/RelayOrderReactor.sol index 43e20a0d..769d02b1 100644 --- a/src/reactors/RelayOrderReactor.sol +++ b/src/reactors/RelayOrderReactor.sol @@ -30,11 +30,8 @@ contract RelayOrderReactor is ReactorEvents, ReactorErrors, ReentrancyGuard, IRe /// @notice permit2 address used for token transfers and signature verification IPermit2 public immutable permit2; - address public immutable universalRouter; - - constructor(IPermit2 _permit2, address _universalRouter) { + constructor(IPermit2 _permit2) { permit2 = _permit2; - universalRouter = _universalRouter; } function execute(SignedOrder calldata order) external payable nonReentrant { diff --git a/test/foundry-tests/integration/RelayOrderReactorIntegration.t.sol b/test/foundry-tests/integration/RelayOrderReactorIntegration.t.sol index 0d0f26ed..c205eb5a 100644 --- a/test/foundry-tests/integration/RelayOrderReactorIntegration.t.sol +++ b/test/foundry-tests/integration/RelayOrderReactorIntegration.t.sol @@ -64,7 +64,7 @@ contract RelayOrderReactorIntegrationTest is GasSnapshot, Test, Interop, PermitS json = vm.readFile(string.concat(root, "/test/foundry-tests/interop.json")); vm.createSelectFork(vm.envString("FOUNDRY_RPC_URL"), 17972788); - deployCodeTo("RelayOrderReactor.sol", abi.encode(PERMIT2, UNIVERSAL_ROUTER), RELAY_ORDER_REACTOR); + deployCodeTo("RelayOrderReactor.sol", abi.encode(PERMIT2), RELAY_ORDER_REACTOR); reactor = RelayOrderReactor(RELAY_ORDER_REACTOR); permitExecutor = new PermitExecutor(address(filler), reactor, address(filler));