Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add core feature alert gh action #8948

Merged
merged 4 commits into from
Dec 10, 2024
Merged

feat: add core feature alert gh action #8948

merged 4 commits into from
Dec 10, 2024

Conversation

FredrikOseberg
Copy link
Contributor

@FredrikOseberg FredrikOseberg commented Dec 10, 2024

Adds a GH action that notifies us that core features were changed. The action listens on paths in the source code where our client api and frontend api are located. If there is a change to these files, we add a comment to the PR to review carefully and add principals and CTO as reviewers.

Copy link

vercel bot commented Dec 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
unleash-monorepo-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 10, 2024 9:00am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
unleash-docs ⬜️ Ignored (Inspect) Visit Preview Dec 10, 2024 9:00am

Copy link
Contributor

github-actions bot commented Dec 10, 2024

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails
actions/actions/github-script 6.*.* 🟢 6.2
Details
CheckScoreReason
Code-Review🟢 10all changesets reviewed
Maintained🟢 66 commit(s) and 2 issue activity found in the last 90 days -- score normalized to 6
Packaging⚠️ -1packaging workflow not detected
Dangerous-Workflow🟢 10no dangerous workflow patterns detected
Token-Permissions⚠️ 0detected GitHub workflow tokens with excessive permissions
Fuzzing⚠️ 0project is not fuzzed
CII-Best-Practices⚠️ 0no effort to earn an OpenSSF best practices badge detected
Binary-Artifacts🟢 10no binaries found in the repo
License🟢 10license file detected
Signed-Releases⚠️ -1no releases found
Pinned-Dependencies⚠️ 1dependency not pinned by hash detected -- score normalized to 1
Security-Policy🟢 9security policy file detected
Branch-Protection⚠️ -1internal error: error during branchesHandler.setup: internal error: githubv4.Query: Resource not accessible by integration
SAST🟢 10SAST tool is run on all commits
Vulnerabilities🟢 46 existing vulnerabilities detected

Scanned Files

  • .github/workflows/core-feature-alert.yml

Copy link
Contributor

@FredrikOseberg, core features have been modified in this pull request. Please review carefully!

@github-actions github-actions bot requested review from chriswk and ivarconr December 10, 2024 08:11
@Unleash Unleash deleted a comment from github-actions bot Dec 10, 2024
@@ -40,6 +40,7 @@ export class ClientFeatureToggleService {
query || {},
);

console.log('ALTERING CLIENT FEATURES');
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will be removed before merge. Used to trigger the action.

Copy link
Member

@chriswk chriswk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FredrikOseberg FredrikOseberg merged commit dfcb196 into main Dec 10, 2024
11 checks passed
@FredrikOseberg FredrikOseberg deleted the feat/cf-alert branch December 10, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants