Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wally produces flat file structure #15

Closed
LastTalon opened this issue Aug 4, 2021 · 5 comments · Fixed by #33
Closed

Wally produces flat file structure #15

LastTalon opened this issue Aug 4, 2021 · 5 comments · Fixed by #33
Labels
bug Something isn't working

Comments

@LastTalon
Copy link
Contributor

For rodux and roact-rodux wally produces a flat file structure with backslashes in the names rather than the hierarchy it means to create. It creates the file structure normally for roact.

Happens with the linux release binary and when building from source on linux with v0.1.1.

File Structure 1 File Structure 2

@LPGhatguy LPGhatguy added the bug Something isn't working label Aug 4, 2021
@LPGhatguy
Copy link
Contributor

What the heck, that's a weird bug.

@magnalite
Copy link
Member

It looks like the zip files themselves are broken like this! As opposed to this being an extraction issue on Linux. I think I accidentally broke all the packages when I republished them to change the project.json files. I assume that means this is an issue with zipping up packages on MacOS (and maybe linux).

@magnalite
Copy link
Member

magnalite commented Aug 6, 2021

Looks like I messed up publishing somehow. I republished them again, using the exact same binary as last time, and they are fine now. Not sure how that happened but I don't think this is an issue we need to be immediately concerned with.

@magnalite magnalite reopened this Oct 5, 2021
@magnalite
Copy link
Member

This has occurred with another package uploaded via the wally cli. This seems to have happened to: reselim/flipper@2.0.0, reselim/roact-flipper@1.1.0 and reselim/roact-router@1.0.0.

@magnalite
Copy link
Member

It appears that unix -> windows is fine, windows -> windows is fine, but windows -> unix is flattened. (zipping -> unzipping)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants