Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tslint error #65

Closed
lookfirst opened this issue Aug 9, 2019 · 7 comments
Closed

tslint error #65

lookfirst opened this issue Aug 9, 2019 · 7 comments

Comments

@lookfirst
Copy link
Contributor

Latest version...

node_modules/graphql-scalars/dist/esnext/resolvers/index.d.ts:27:70 - error TS7016: Could not find a declaration file for module 'graphql-type-json'. '/node_modules/graphql-type-json/lib/index.js' implicitly has an 'any' type.
  Try `npm install @types/graphql-type-json` if it exists or add a new declaration (.d.ts) file containing `declare module 'graphql-type-json';`

27 import { GraphQLJSON as JSON, GraphQLJSONObject as JSONObject } from 'graphql-type-json';
@ardatan
Copy link
Collaborator

ardatan commented Aug 12, 2019

Could you try with the following canary version?

1.0.1-7c4ff75.0 

@lookfirst
Copy link
Contributor Author

Shouldn't this be in your bundle test?

@ardatan
Copy link
Collaborator

ardatan commented Aug 12, 2019

The idea behind having this bundle-test is to check the size of this package inside a project. But we can add this kind of a test to have strict type checking for the library in point of another project. I'll take care of it. In addition, could you confirm it works for you?

@lookfirst
Copy link
Contributor Author

I'll confirm it after you confirm it works on CI. ;-)

@ardatan
Copy link
Collaborator

ardatan commented Aug 12, 2019

@lookfirst You can create a PR to have this kind of test on CI, then I confirm it works on CI before you say your confirmation that I am looking forward to :)

@lookfirst
Copy link
Contributor Author

Aug-12-2019 19-08-40

@lookfirst
Copy link
Contributor Author

fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants