Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add msrv verify as ci check #480

Merged
merged 2 commits into from
Feb 28, 2024
Merged

test: add msrv verify as ci check #480

merged 2 commits into from
Feb 28, 2024

Conversation

V0ldek
Copy link
Member

@V0ldek V0ldek commented Feb 28, 2024

Short description

The MSRV got unknowingly bumped before, with this CI check we will avoid it in the future.

This also fixes a violation of MSRV in rsonpath-syntax unknowingly introduced in #477

Checklist

All of these should be ticked off before you submit the PR.

  • I ran just verify locally and it succeeded.
  • Issue was given go ahead and is linked above OR I have included justification for a minor change.
  • Unit tests for my changes are included OR no functionality was changed.

The MSRV got unknowingly bumped before,
with this CI check we will avoid it in the future.
@V0ldek V0ldek merged commit e40f464 into main Feb 28, 2024
46 checks passed
@V0ldek V0ldek deleted the v0ldek/msrv-workflow branch February 28, 2024 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant