Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Разделить settlingHeight и fullscreen #1697

Closed
eolme opened this issue Jun 23, 2021 · 1 comment · Fixed by #6759
Closed

[Feature] Разделить settlingHeight и fullscreen #1697

eolme opened this issue Jun 23, 2021 · 1 comment · Fixed by #6759
Assignees
@inomdzhon
Labels
cmp:modal type:feature
Milestone
v7.0.0

Comments

@eolme
Copy link
Contributor

eolme commented Jun 23, 2021

После #1340 теперь нельзя открывать модалку на максимум:

  • при установке в 100, если контент маленький, остается пространство снизу
  • если не ставить 100 и контента много, то она по-умолчанию открывается на 75
@eolme eolme mentioned this issue Oct 31, 2021
Closed
@SevereCloud SevereCloud moved this to Backlog in VKUI Aug 1, 2022
@SevereCloud SevereCloud added this to VKUI Aug 1, 2022
@SevereCloud SevereCloud self-assigned this Jun 26, 2023
@inomdzhon inomdzhon mentioned this issue May 22, 2024
Merged
8 tasks
@SevereCloud SevereCloud removed their assignment Jul 28, 2024
@inomdzhon inomdzhon added this to the v7.0.0 milestone Nov 28, 2024
@inomdzhon inomdzhon self-assigned this Nov 28, 2024
@github-project-automation github-project-automation bot moved this from 🗃 Backlog to ✅ Done in VKUI Dec 2, 2024
@vkcom-publisher
Copy link
Contributor

✅ v7.0.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@inomdzhon inomdzhon

Labels
cmp:modal type:feature
Projects
VKUI
Archived in project
Milestone
v7.0.0
Development

Successfully merging a pull request may close this issue.

refactor: ModalRoot/ModalPage/ModalCard VKCOM/VKUI
5 participants
@ArthurStam @inomdzhon @eolme @SevereCloud @vkcom-publisher