Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: CustomScrollView следит только за резайзом window, но не блоком где юзается #7043

Closed
daniil-kaverzin opened this issue Jun 21, 2024 · 1 comment · Fixed by #7060
Closed

[Bug]: CustomScrollView следит только за резайзом window, но не блоком где юзается #7043

daniil-kaverzin opened this issue Jun 21, 2024 · 1 comment · Fixed by #7060
Assignees
@EldarMuhamethanov
Labels
cmp:custom-scroll-view type:bug
Milestone
v6.1.2

Comments

@daniil-kaverzin
Copy link
Contributor

Описание

CustomScrollView следит только за резайзом window, но не блоком где юзается

Версия

6.1.1

В каких браузерах воспроизводится проблема?

Firefox, Chrome, Safari, Microsoft Edge, Yandex Browser

Шаги воспроизведения

Делаем внутри CustomScrollView появление какого-то контента, который не вызывает ререндер всего CustomScrollView, дергалка скролла справа себя не апдейтит на ресайз

Ожидаемое поведение

Вызывается перерасчет всех штуковин внутри CustomScrollView на ресайз блока

Скриншоты

image

Пример с воспроизведением

https://codesandbox.io/p/sandbox/objective-hermann-537g7j?file=/src/App.tsx
@inomdzhon inomdzhon self-assigned this Jun 21, 2024
@inomdzhon inomdzhon added this to VKUI Jun 21, 2024
@github-project-automation github-project-automation bot moved this to 🗃 Backlog in VKUI Jun 21, 2024
@inomdzhon inomdzhon moved this from 🗃 Backlog to 🔜 To do in VKUI Jun 21, 2024
@inomdzhon inomdzhon moved this from 🔜 To do to 🔧 In progress in VKUI Jun 21, 2024
@EldarMuhamethanov EldarMuhamethanov mentioned this issue Jun 24, 2024
Merged
1 task
@EldarMuhamethanov EldarMuhamethanov moved this from 🔧 In progress to 👀 In Review in VKUI Jun 24, 2024
@inomdzhon inomdzhon added this to the v6.1.2 milestone Jun 24, 2024
@github-project-automation github-project-automation bot moved this from 👀 In Review to ✅ Done in VKUI Jun 24, 2024
@vkcom-publisher
Copy link
Contributor

✅ v6.1.2 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EldarMuhamethanov EldarMuhamethanov

Labels
cmp:custom-scroll-view type:bug
Projects
VKUI
Archived in project
Milestone
v6.1.2
Development

Successfully merging a pull request may close this issue.

fix(CustomScrollView): add resize container handler VKCOM/VKUI
4 participants
@inomdzhon @daniil-kaverzin @EldarMuhamethanov @vkcom-publisher