Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature][Button]: Тёмная кнопка в режиме Appearance = Overlay, Mode = Secondary #7659

Closed
qurle opened this issue Sep 24, 2024 · 2 comments · Fixed by #7661
Closed

[Feature][Button]: Тёмная кнопка в режиме Appearance = Overlay, Mode = Secondary #7659

qurle opened this issue Sep 24, 2024 · 2 comments · Fixed by #7661
Assignees
@EldarMuhamethanov
Labels
breaking-change cmp:button type:feature
Milestone
v7.0.0

Comments

@qurle
Copy link
Contributor

qurle commented Sep 24, 2024 •
edited
Loading

Из-за того, что вторичные оверлейные кнопки — сочетание белого текста на полупрозрачном белом фоне, они работают непредсказуемо на фотографиях.

Давайте поменяем цвет фона у Button с appearance = overlay, mode = secondary на --vkui__color_overlay_primary. И соответствующие цвета у :hover и :active состояний.

image

image
@qurle qurle added this to the v7.0.0 milestone Sep 24, 2024
@qurle qurle added this to VKUI Sep 24, 2024
@github-project-automation github-project-automation bot moved this to 🗃 Backlog in VKUI Sep 24, 2024
@EldarMuhamethanov EldarMuhamethanov mentioned this issue Sep 25, 2024
Merged
3 tasks
@github-project-automation github-project-automation bot moved this from 👀 In Review to ✅ Done in VKUI Sep 27, 2024
@vkcom-publisher
Copy link
Contributor

✅ v7.0.0-beta.0 🎉

@inomdzhon inomdzhon modified the milestones: v7.0.0-beta.0, v7.0.0 Dec 2, 2024
@vkcom-publisher
Copy link
Contributor

✅ v7.0.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EldarMuhamethanov EldarMuhamethanov

Labels
breaking-change cmp:button type:feature
Projects
VKUI
Archived in project
Milestone
v7.0.0
4 participants
@inomdzhon @qurle @EldarMuhamethanov @vkcom-publisher