Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Button): Fix counter bg color in buttons #5532

Merged
merged 2 commits into from
Jul 31, 2023

Conversation

BlackySoul
Copy link
Contributor

  • исправляем background-color для Counter в Button (mode:primary)
  • добавила e2e-тесты, чтобы быстрее отлавливать баги

@BlackySoul BlackySoul requested a review from a team as a code owner July 27, 2023 15:16
@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 27, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit e5aa110:

Sandbox Source
VKUI TypeScript Configuration

@github-actions
Copy link
Contributor

github-actions bot commented Jul 27, 2023

👀 Docs deployed

Commit e5aa110

@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (29c5b59) 81.69% compared to head (e5aa110) 81.70%.
Report is 9 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5532   +/-   ##
=======================================
  Coverage   81.69%   81.70%           
=======================================
  Files         286      286           
  Lines        9575     9585   +10     
  Branches     3054     3057    +3     
=======================================
+ Hits         7822     7831    +9     
- Misses       1753     1754    +1     
Flag Coverage Δ
unittests 81.70% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 27, 2023

size-limit report 📦

Path Size
JS 311.65 KB (0%)
JS (gzip) 91.17 KB (0%)
JS (brotli) 75.66 KB (0%)
JS import Div (tree shaking) 2.97 KB (0%)
CSS 271.45 KB (+0.01% 🔺)
CSS (gzip) 35.56 KB (-0.01% 🔽)
CSS (brotli) 28.19 KB (-0.09% 🔽)

@github-actions
Copy link
Contributor

github-actions bot commented Jul 27, 2023

e2e tests

Playwright Report

SevereCloud
SevereCloud previously approved these changes Jul 28, 2023
@BlackySoul BlackySoul merged commit be4cf99 into master Jul 31, 2023
@BlackySoul BlackySoul deleted the blackysoul/fix_button_counter_color branch July 31, 2023 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants