Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add RootComponent #5651

Merged
merged 1 commit into from
Aug 22, 2023

Conversation

SevereCloud
Copy link
Contributor

@SevereCloud SevereCloud commented Aug 18, 2023

Добавляем тесты на getRootRef и абстракцию RootComponent. Позволило немного уменьшить общий бандл

@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 18, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 2310bae:

Sandbox Source
VKUI TypeScript Configuration

@github-actions
Copy link
Contributor

github-actions bot commented Aug 18, 2023

size-limit report 📦

Path Size
JS 315.73 KB (-0.62% 🔽)
JS (gzip) 93.01 KB (-0.38% 🔽)
JS (brotli) 76.92 KB (-0.2% 🔽)
JS import Div (tree shaking) 3.04 KB (+2.27% 🔺)
CSS 275.81 KB (0%)
CSS (gzip) 36.01 KB (0%)
CSS (brotli) 28.57 KB (0%)

@github-actions
Copy link
Contributor

github-actions bot commented Aug 18, 2023

👀 Docs deployed

Commit 2310bae

@codecov
Copy link

codecov bot commented Aug 18, 2023

Codecov Report

Patch coverage: 95.83% and project coverage change: -0.06% ⚠️

Comparison is base (edcc8bb) 81.95% compared to head (2310bae) 81.90%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5651      +/-   ##
==========================================
- Coverage   81.95%   81.90%   -0.06%     
==========================================
  Files         295      296       +1     
  Lines        9804     9765      -39     
  Branches     3095     3094       -1     
==========================================
- Hits         8035     7998      -37     
+ Misses       1769     1767       -2     
Flag Coverage Δ
unittests 81.90% <95.83%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...ui/src/components/Cell/CellDragger/CellDragger.tsx 94.73% <ø> (ø)
packages/vkui/src/components/Counter/Counter.tsx 100.00% <ø> (ø)
...ents/CustomSelectDropdown/CustomSelectDropdown.tsx 100.00% <ø> (ø)
...mponents/CustomSelectOption/CustomSelectOption.tsx 92.85% <ø> (ø)
.../vkui/src/components/DropdownIcon/DropdownIcon.tsx 100.00% <ø> (ø)
...es/vkui/src/components/FixedLayout/FixedLayout.tsx 94.87% <ø> (ø)
...ages/vkui/src/components/FormStatus/FormStatus.tsx 83.33% <ø> (ø)
...i/src/components/HorizontalCell/HorizontalCell.tsx 83.33% <ø> (ø)
packages/vkui/src/components/InfoRow/InfoRow.tsx 88.88% <ø> (ø)
...mponents/ModalDismissButton/ModalDismissButton.tsx 100.00% <ø> (ø)
... and 74 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SevereCloud SevereCloud force-pushed the SevereCloud/refactor--add-RootComponent branch 2 times, most recently from db4eb66 to 661468e Compare August 21, 2023 09:34
@github-actions
Copy link
Contributor

github-actions bot commented Aug 21, 2023

e2e tests

Playwright Report

@SevereCloud SevereCloud force-pushed the SevereCloud/refactor--add-RootComponent branch from 661468e to f48301e Compare August 21, 2023 11:18
@SevereCloud SevereCloud marked this pull request as ready for review August 21, 2023 12:02
@SevereCloud SevereCloud requested a review from a team as a code owner August 21, 2023 12:02
@SevereCloud SevereCloud force-pushed the SevereCloud/refactor--add-RootComponent branch from f48301e to 643c310 Compare August 22, 2023 11:40
@SevereCloud SevereCloud force-pushed the SevereCloud/refactor--add-RootComponent branch from 643c310 to 2310bae Compare August 22, 2023 11:51
Copy link
Contributor

@mendrew mendrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Отличная работа! 💯

@SevereCloud SevereCloud merged commit fd49482 into master Aug 22, 2023
@SevereCloud SevereCloud deleted the SevereCloud/refactor--add-RootComponent branch August 22, 2023 14:23
@thoughtspile
Copy link
Contributor

@SevereCloud горжусь вами 🥇

Раз уж есть RootComponent, я бы встроил в него classNames и разрешил baseClassName: string | (string | Record<string, boolean>)[], –1 импорт в каждом компоненте

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Поддержать getRootRef на всех компонентах
4 participants