-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: add RootComponent #5651
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 2310bae:
|
size-limit report 📦
|
👀 Docs deployedCommit 2310bae |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #5651 +/- ##
==========================================
- Coverage 81.95% 81.90% -0.06%
==========================================
Files 295 296 +1
Lines 9804 9765 -39
Branches 3095 3094 -1
==========================================
- Hits 8035 7998 -37
+ Misses 1769 1767 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
db4eb66
to
661468e
Compare
e2e tests |
661468e
to
f48301e
Compare
f48301e
to
643c310
Compare
643c310
to
2310bae
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Отличная работа! 💯
@SevereCloud горжусь вами 🥇 Раз уж есть |
Добавляем тесты на getRootRef и абстракцию RootComponent. Позволило немного уменьшить общий бандл