Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(useAdaptivityHasHover): two pass rendering #5668

Merged

Conversation

SevereCloud
Copy link
Contributor

@SevereCloud SevereCloud commented Aug 21, 2023

Не используем двойной рендер если
значение было проброшено через контекст

useAdaptivityHasPointer

Поправили условие из PR #5666

Не используем двойной рендер если
значение было проброшено через контекст
@SevereCloud SevereCloud requested a review from a team as a code owner August 21, 2023 10:39
@SevereCloud SevereCloud added the patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча label Aug 21, 2023
@SevereCloud SevereCloud added this to the v5.7.2 milestone Aug 21, 2023
@SevereCloud SevereCloud self-assigned this Aug 21, 2023
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 0cc8361:

Sandbox Source
VKUI TypeScript Configuration

@codecov
Copy link

codecov bot commented Aug 21, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (058e705) 81.83% compared to head (0cc8361) 81.83%.
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5668   +/-   ##
=======================================
  Coverage   81.83%   81.83%           
=======================================
  Files         294      294           
  Lines        9767     9768    +1     
  Branches     3111     3112    +1     
=======================================
+ Hits         7993     7994    +1     
  Misses       1774     1774           
Flag Coverage Δ
unittests 81.83% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
packages/vkui/src/hooks/useAdaptivityHasHover.ts 100.00% <100.00%> (ø)
packages/vkui/src/hooks/useAdaptivityHasPointer.ts 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
JS 317.41 KB (-0.02% 🔽)
JS (gzip) 93.12 KB (-0.04% 🔽)
JS (brotli) 77 KB (-0.05% 🔽)
JS import Div (tree shaking) 2.97 KB (0%)
CSS 276.36 KB (+0.17% 🔺)
CSS (gzip) 36.05 KB (+0.05% 🔺)
CSS (brotli) 28.6 KB (+0.07% 🔺)

@github-actions
Copy link
Contributor

👀 Docs deployed

Commit 0cc8361

@github-actions
Copy link
Contributor

e2e tests

Playwright Report

@SevereCloud SevereCloud merged commit ba603f8 into master Aug 22, 2023
@SevereCloud SevereCloud deleted the SevereCloud/fix-useAdaptivityHasHover/two-pass-rendering branch August 22, 2023 07:48
vkcom-publisher pushed a commit that referenced this pull request Aug 22, 2023
Не используем двойной рендер если
значение было проброшено через контекст
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
adaptivity patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча type:bug
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants