Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AppRoot mode #5720

Merged
merged 1 commit into from
Aug 31, 2023
Merged

Fix AppRoot mode #5720

merged 1 commit into from
Aug 31, 2023

Conversation

BlackySoul
Copy link
Contributor

@BlackySoul BlackySoul commented Aug 31, 2023

Добавляем условие, чтобы не аффектило отличные от embedded режимы подключения

@BlackySoul BlackySoul requested a review from a team as a code owner August 31, 2023 04:20
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 10ca79b:

Sandbox Source
VKUI TypeScript Configuration

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
JS 316.12 KB (+0.01% 🔺)
JS (gzip) 93.13 KB (+0.01% 🔺)
JS (brotli) 77.05 KB (+0.11% 🔺)
JS import Div (tree shaking) 3.04 KB (0%)
CSS 275.8 KB (0%)
CSS (gzip) 36.01 KB (0%)
CSS (brotli) 28.56 KB (0%)

@github-actions
Copy link
Contributor

e2e tests

Playwright Report

@github-actions
Copy link
Contributor

👀 Docs deployed

Commit 10ca79b

@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (38a57c6) 81.93% compared to head (10ca79b) 81.93%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5720   +/-   ##
=======================================
  Coverage   81.93%   81.93%           
=======================================
  Files         296      296           
  Lines        9780     9780           
  Branches     3102     3102           
=======================================
  Hits         8013     8013           
  Misses       1767     1767           
Flag Coverage Δ
unittests 81.93% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
packages/vkui/src/components/AppRoot/AppRoot.tsx 92.66% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BlackySoul BlackySoul self-assigned this Aug 31, 2023
@BlackySoul BlackySoul merged commit 156b2cf into master Aug 31, 2023
25 checks passed
@BlackySoul BlackySoul deleted the BlackySoul-patch-1 branch August 31, 2023 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants