Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add useNavId #5743

Merged
merged 1 commit into from
Sep 6, 2023
Merged

feat: add useNavId #5743

merged 1 commit into from
Sep 6, 2023

Conversation

SevereCloud
Copy link
Contributor

@SevereCloud SevereCloud requested a review from a team as a code owner September 4, 2023 11:15
@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 4, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit db99041:

Sandbox Source
VKUI TypeScript Configuration

@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2023

size-limit report 📦

Path Size
JS 347.19 KB (+0.08% 🔺)
JS (gzip) 103.92 KB (+0.1% 🔺)
JS (brotli) 84.62 KB (+0.2% 🔺)
JS import Div (tree shaking) 3.04 KB (0%)
CSS 277.75 KB (0%)
CSS (gzip) 36.21 KB (0%)
CSS (brotli) 28.65 KB (0%)

@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2023

e2e tests

Playwright Report

@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2023

👀 Docs deployed

Commit db99041

@codecov
Copy link

codecov bot commented Sep 4, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.02% 🎉

Comparison is base (6602652) 81.96% compared to head (db99041) 81.98%.
Report is 11 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5743      +/-   ##
==========================================
+ Coverage   81.96%   81.98%   +0.02%     
==========================================
  Files         296      298       +2     
  Lines        9819     9830      +11     
  Branches     3107     3109       +2     
==========================================
+ Hits         8048     8059      +11     
  Misses       1771     1771              
Flag Coverage Δ
unittests 81.98% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
.../vkui/src/components/NavIdContext/NavIdContext.tsx 100.00% <100.00%> (ø)
...kages/vkui/src/components/NavIdContext/useNavId.ts 100.00% <100.00%> (ø)
packages/vkui/src/components/Panel/Panel.tsx 100.00% <100.00%> (ø)
packages/vkui/src/components/View/View.tsx 93.01% <100.00%> (+0.02%) ⬆️
packages/vkui/src/components/View/ViewInfinite.tsx 91.33% <100.00%> (+0.06%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

mendrew
mendrew previously approved these changes Sep 5, 2023
Copy link
Contributor

@mendrew mendrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Выглядит прекрасно 💯

@SevereCloud SevereCloud force-pushed the SevereCloud/issue1653 branch from 20d6d84 to db99041 Compare September 6, 2023 07:13
@SevereCloud SevereCloud changed the title feat: add useNavID feat: add useNavId Sep 6, 2023
@SevereCloud SevereCloud added the v5 Автоматизация: PR продублируется в ветку v5 label Sep 6, 2023
@SevereCloud SevereCloud merged commit f89fa96 into master Sep 6, 2023
23 checks passed
@SevereCloud SevereCloud deleted the SevereCloud/issue1653 branch September 6, 2023 12:42
vkcom-publisher pushed a commit that referenced this pull request Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v5 Автоматизация: PR продублируется в ветку v5
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] NavigationProvider
3 participants